Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 2254543003: cc: Delete the RendererClient class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setvisible-browser
Patch Set: deleterendererclient: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index e2dbba06fd19fba4d4c501073bd104f508eddba0..9ba449b0c6ac3d82a39fdd70b5650e4a2f9b9b45 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -1517,7 +1517,7 @@ void LayerTreeHostImpl::SetExternalTilePriorityConstraints(
// Compositor, not OutputSurface, is responsible for setting damage and
// triggering redraw for constraint changes.
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
SetNeedsRedraw();
}
}
@@ -1589,7 +1589,7 @@ void LayerTreeHostImpl::OnDraw(const gfx::Transform& transform,
// always swap. Otherwise, need to set redraw for any changes to draw
// parameters.
if (transform_changed || viewport_changed || resourceless_software_draw_) {
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
SetNeedsRedraw();
active_tree_->set_needs_update_draw_properties();
}
@@ -1607,7 +1607,7 @@ void LayerTreeHostImpl::OnDraw(const gfx::Transform& transform,
// This draw may have reset all damage, which would lead to subsequent
// incorrect hardware draw, so explicitly set damage for next hardware
// draw as well.
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
}
}
@@ -2094,11 +2094,9 @@ void LayerTreeHostImpl::SetVisible(bool visible) {
SetRequiresHighResToDraw();
} else {
EvictAllUIResources();
- }
-
- // Call PrepareTiles to evict tiles when we become invisible.
- if (!visible)
+ // Call PrepareTiles to evict tiles when we become invisible.
PrepareTiles();
+ }
// Update visibility for the compositor context provider.
if (output_surface_) {
@@ -2161,10 +2159,9 @@ void LayerTreeHostImpl::CreateAndSetRenderer() {
DCHECK(output_surface_->capabilities().delegated_rendering);
renderer_ = base::MakeUnique<DelegatingRenderer>(
- this, &settings_.renderer_settings, output_surface_,
- resource_provider_.get());
+ &settings_.renderer_settings, output_surface_, resource_provider_.get());
renderer_->SetVisible(visible_);
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
// See note in LayerTreeImpl::UpdateDrawProperties. Renderer needs to be
// initialized to get max texture size. Also, after releasing resources,
@@ -2412,7 +2409,7 @@ void LayerTreeHostImpl::SetViewportSize(const gfx::Size& device_viewport_size) {
UpdateViewportContainerSizes();
client_->OnCanDrawStateChanged(CanDraw());
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
active_tree_->set_needs_update_draw_properties();
}
@@ -2443,7 +2440,7 @@ void LayerTreeHostImpl::DidChangeTopControlsPosition() {
SetNeedsRedraw();
SetNeedsOneBeginImplFrame();
active_tree_->set_needs_update_draw_properties();
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
}
float LayerTreeHostImpl::TopControlsHeight() const {
@@ -3217,7 +3214,7 @@ void LayerTreeHostImpl::SetSynchronousInputHandlerRootScrollOffset(
// After applying the synchronous input handler's scroll offset, tell it what
// we ended up with.
UpdateRootLayerStateForSynchronousInputHandler();
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
SetNeedsRedraw();
}
@@ -3403,7 +3400,7 @@ std::unique_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
return scroll_info;
}
-void LayerTreeHostImpl::SetFullRootLayerDamage() {
+void LayerTreeHostImpl::SetFullViewportDamage() {
SetViewportDamage(gfx::Rect(DrawViewportSize()));
}
@@ -3692,7 +3689,7 @@ void LayerTreeHostImpl::SetDebugState(
debug_state_ = new_debug_state;
UpdateTileManagerMemoryPolicy(ActualManagedMemoryPolicy());
- SetFullRootLayerDamage();
+ SetFullViewportDamage();
}
void LayerTreeHostImpl::CreateUIResource(UIResourceId uid,
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698