Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2254533003: Rename spellcheck::pref::kEnableContinuousSpellcheck to ...::kEnableSpellcheck (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename spellcheck::pref::kEnableContinuousSpellcheck to ...::kEnableSpellcheck This patch does the above renaming because "continuous spell checking" is a name that does not make too much sense, and the renamed flag is simply indicating whether spell checking is enabled. This patch does exactly 's/kEnableContinuousSpellcheck/kEnableSpellCheck/g'. This is a followup patch of http://crrev.com/2251693003 that does the same renaming in Blink. BUG=638191 Committed: https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94 Cr-Commit-Position: refs/heads/master@{#413043}

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 29 (17 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-17 06:13:10 UTC) #5
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-17 14:46:44 UTC) #8
please use gerrit instead
lgtm
4 years, 4 months ago (2016-08-17 16:01:25 UTC) #9
Xiaocheng
Thanks!
4 years, 4 months ago (2016-08-17 16:37:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254533003/1
4 years, 4 months ago (2016-08-17 16:37:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/239946)
4 years, 4 months ago (2016-08-17 16:43:13 UTC) #14
Xiaocheng
+timvolodine: This patch has conflict with the spellchecker componentization that you are working on. Could ...
4 years, 4 months ago (2016-08-18 01:18:44 UTC) #16
timvolodine
On 2016/08/18 01:18:44, Xiaocheng wrote: > +timvolodine: > > This patch has conflict with the ...
4 years, 4 months ago (2016-08-18 12:10:56 UTC) #17
Xiaocheng
There's nothing to sorry about :) I'm committing this simple patch, which is just find ...
4 years, 4 months ago (2016-08-19 03:18:19 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254533003/20001
4 years, 4 months ago (2016-08-19 03:18:43 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 03:22:39 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 03:24:24 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94
Cr-Commit-Position: refs/heads/master@{#413043}

Powered by Google App Engine
This is Rietveld 408576698