Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2254513002: Remove SkPreprocessorSeq.h and SkTypedEnum.h. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkPreprocessorSeq.h and SkTypedEnum.h. These were added to allow the use of typed enums before typed enums were available on all platforms. Now that typed enums are available, just use them directly. Committed: https://skia.googlesource.com/skia/+/8fd23a86d0d16c93e4fa08f79cdcca4b48b6d7f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1135 lines, -2120 lines) Patch
M gyp/sfnt.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/sfnt/SkIBMFamilyClass.h View 1 chunk +101 lines, -113 lines 0 comments Download
M src/sfnt/SkOTTable_EBDT.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/sfnt/SkOTTable_EBLC.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2_V0.h View 2 chunks +22 lines, -25 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2_V1.h View 2 chunks +22 lines, -25 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2_V2.h View 2 chunks +22 lines, -24 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2_V3.h View 2 chunks +22 lines, -25 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2_V4.h View 2 chunks +22 lines, -25 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2_VA.h View 2 chunks +22 lines, -23 lines 0 comments Download
M src/sfnt/SkOTTable_gasp.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/sfnt/SkOTTable_glyf.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/sfnt/SkOTTable_head.h View 2 chunks +14 lines, -18 lines 0 comments Download
M src/sfnt/SkOTTable_hhea.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/sfnt/SkOTTable_maxp_TT.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/sfnt/SkOTTable_name.h View 7 chunks +417 lines, -426 lines 0 comments Download
M src/sfnt/SkOTTable_post.h View 2 chunks +7 lines, -9 lines 0 comments Download
M src/sfnt/SkPanose.h View 1 chunk +451 lines, -489 lines 0 comments Download
D src/sfnt/SkPreprocessorSeq.h View 1 chunk +0 lines, -826 lines 0 comments Download
D src/sfnt/SkTypedEnum.h View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bungeman-skia
This CL is kinda big, but very mechanical. This doesn't attempt to actually clean anything ...
4 years, 4 months ago (2016-08-16 18:52:40 UTC) #6
hal.canary
lgtm
4 years, 4 months ago (2016-08-16 19:26:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254513002/1
4 years, 4 months ago (2016-08-16 19:26:51 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 19:27:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8fd23a86d0d16c93e4fa08f79cdcca4b48b6d7f9

Powered by Google App Engine
This is Rietveld 408576698