Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2254503002: Change VideoFrameCompositor events to be async. (Closed)

Created:
4 years, 4 months ago by alexandermont
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change VideoFrameCompositor events from a start/stop pair to AsyncEvents. BUG=catapult:2683 Committed: https://crrev.com/7de4d26d40e26626d70cf5cb2420d4e10ca0f620 Cr-Commit-Position: refs/heads/master@{#412677}

Patch Set 1 #

Patch Set 2 : fix formatting #

Patch Set 3 : chagne to async events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/blink/video_frame_compositor.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
alexandermont
4 years, 4 months ago (2016-08-16 22:14:52 UTC) #2
Ken Russell (switch to Gerrit)
LGTM if this has been tested. Please reference a bug ID with more background information ...
4 years, 4 months ago (2016-08-17 07:28:46 UTC) #3
alexandermont
4 years, 4 months ago (2016-08-17 18:41:53 UTC) #5
Ken Russell (switch to Gerrit)
Seems fine though I don't understand all the consequences of this change. Still LGTM.
4 years, 4 months ago (2016-08-17 18:44:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254503002/40001
4 years, 4 months ago (2016-08-17 18:54:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/240073)
4 years, 4 months ago (2016-08-17 19:02:23 UTC) #10
Ken Russell (switch to Gerrit)
+a couple more OWNERS
4 years, 4 months ago (2016-08-17 20:27:48 UTC) #12
DaleCurtis
Why the name change?
4 years, 4 months ago (2016-08-17 20:29:16 UTC) #13
alexandermont1
On 2016/08/17 at 20:29:16, dalecurtis wrote: > Why the name change? Because originally this was ...
4 years, 4 months ago (2016-08-17 20:40:14 UTC) #14
DaleCurtis
Seems okay, I'm not strongly tied to the name. lgtm
4 years, 4 months ago (2016-08-17 20:41:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254503002/40001
4 years, 4 months ago (2016-08-17 22:51:13 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 22:55:57 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 22:58:40 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7de4d26d40e26626d70cf5cb2420d4e10ca0f620
Cr-Commit-Position: refs/heads/master@{#412677}

Powered by Google App Engine
This is Rietveld 408576698