|
|
Created:
4 years, 4 months ago by alexandermont Modified:
4 years, 4 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange VideoFrameCompositor events from a start/stop pair to AsyncEvents.
BUG=catapult:2683
Committed: https://crrev.com/7de4d26d40e26626d70cf5cb2420d4e10ca0f620
Cr-Commit-Position: refs/heads/master@{#412677}
Patch Set 1 #Patch Set 2 : fix formatting #Patch Set 3 : chagne to async events #Messages
Total messages: 20 (7 generated)
alexandermont@chromium.org changed reviewers: + kbr@chromium.org, wolenetz@chromium.org
LGTM if this has been tested. Please reference a bug ID with more background information in the CL description.
Description was changed from ========== Add video IDs to VideoFrameCompositor events. ========== to ========== Change VideoFrameCompositor events from a start/stop pair to AsyncEvents. BUG=catapult:2683 ==========
Seems fine though I don't understand all the consequences of this change. Still LGTM.
The CQ bit was checked by alexandermont@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
kbr@chromium.org changed reviewers: + dalecurtis@chromium.org, hubbe@chromium.org
+a couple more OWNERS
Why the name change?
On 2016/08/17 at 20:29:16, dalecurtis wrote: > Why the name change? Because originally this was separate start and stop events, so the trace event names were the same as the function name. Now it's just one async event, so I made the name be something that describes what's going on through the whole event (video playback).
Seems okay, I'm not strongly tied to the name. lgtm
The CQ bit was checked by alexandermont@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Change VideoFrameCompositor events from a start/stop pair to AsyncEvents. BUG=catapult:2683 ========== to ========== Change VideoFrameCompositor events from a start/stop pair to AsyncEvents. BUG=catapult:2683 Committed: https://crrev.com/7de4d26d40e26626d70cf5cb2420d4e10ca0f620 Cr-Commit-Position: refs/heads/master@{#412677} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7de4d26d40e26626d70cf5cb2420d4e10ca0f620 Cr-Commit-Position: refs/heads/master@{#412677} |