Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2254473002: Disable TestGetBenchmarkNamesForFile.testListSimpleBenchmarksDefinedInOneFileComplex on chromeos (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
achuithb
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable TestGetBenchmarkNamesForFile.testListSimpleBenchmarksDefinedInOneFileComplex on chromeos It is causing chromeos telemetry bot failures: https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-telemetry/builds/10190 BUG=637938 TEST=perf tests Committed: https://crrev.com/7fe492ff89e7cf3b3ac5d0e1569ce98d66a9cc67 Cr-Commit-Position: refs/heads/master@{#412282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/core/benchmark_finders_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
James Cook
achuith, can you rubber-stamp?
4 years, 4 months ago (2016-08-16 16:52:36 UTC) #2
achuithb
lgtm
4 years, 4 months ago (2016-08-16 16:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254473002/1
4 years, 4 months ago (2016-08-16 17:09:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 17:50:02 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 17:52:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fe492ff89e7cf3b3ac5d0e1569ce98d66a9cc67
Cr-Commit-Position: refs/heads/master@{#412282}

Powered by Google App Engine
This is Rietveld 408576698