Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2254453002:
Sets the max height of ImeMenuTray. (Closed)
|
Created:
4 years, 4 months ago by Azure Wei Modified:
4 years, 4 months ago Reviewers:
James Cook CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSets the max height of ImeMenuTray.
The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most.
BUG=640427
TEST=Verified on local build.
Committed: https://crrev.com/5ee46213fbcad7272d5b9c9d7a6492598239c2f1
Cr-Commit-Position: refs/heads/master@{#413912}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Defines const int max_items. #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== Sets the max height of ImeMenuTray. BUG=570761 TEST=Verified on local build. ========== to ========== Sets the max height of ImeMenuTray. The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most. BUG=570761 TEST=Verified on local build. ==========
azurewei@chromium.org changed reviewers: + jamescook@chromium.org
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi James, can you take a look at this cl? Thanks!
LGTM https://codereview.chromium.org/2254453002/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right): https://codereview.chromium.org/2254453002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:34: return GetTrayConstant(TRAY_POPUP_ITEM_HEIGHT) * 7; nit: Use a named constant for 7, like const int max_items = 7.
The CQ bit was checked by azurewei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org Link to the patchset: https://codereview.chromium.org/2254453002/#ps20001 (title: "Defines const int max_items.")
On 2016/08/23 15:47:12, James Cook wrote: > LGTM > > https://codereview.chromium.org/2254453002/diff/1/ash/common/system/chromeos/... > File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right): > > https://codereview.chromium.org/2254453002/diff/1/ash/common/system/chromeos/... > ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:34: return > GetTrayConstant(TRAY_POPUP_ITEM_HEIGHT) * 7; > nit: Use a named constant for 7, like const int max_items = 7. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by azurewei@chromium.org
Description was changed from ========== Sets the max height of ImeMenuTray. The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most. BUG=570761 TEST=Verified on local build. ========== to ========== Sets the max height of ImeMenuTray. The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most. BUG=640427 TEST=Verified on local build. ==========
The CQ bit was checked by azurewei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Sets the max height of ImeMenuTray. The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most. BUG=640427 TEST=Verified on local build. ========== to ========== Sets the max height of ImeMenuTray. The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most. BUG=640427 TEST=Verified on local build. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Sets the max height of ImeMenuTray. The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most. BUG=640427 TEST=Verified on local build. ========== to ========== Sets the max height of ImeMenuTray. The bubble for ImeMenuTray has been set with max height, which is ugly with many IME selected. Limits the height to showing 7 items shown at most. BUG=640427 TEST=Verified on local build. Committed: https://crrev.com/5ee46213fbcad7272d5b9c9d7a6492598239c2f1 Cr-Commit-Position: refs/heads/master@{#413912} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5ee46213fbcad7272d5b9c9d7a6492598239c2f1 Cr-Commit-Position: refs/heads/master@{#413912} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
