Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2254433004: Fix bad cast in PaintInvalidationState::updateForNormalChildren() (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
Reviewers:
pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bad cast in PaintInvalidationState::updateForNormalChildren() BUG=638144 Committed: https://crrev.com/8eaf8ebd391c7f6aae667015a940273a917efa9a Cr-Commit-Position: refs/heads/master@{#412327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/svg-clip-crash.svg View 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/invalidation/svg-clip-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xianzhu
4 years, 4 months ago (2016-08-16 16:39:22 UTC) #3
pdr.
On 2016/08/16 at 16:39:22, wangxianzhu wrote: > LGTM
4 years, 4 months ago (2016-08-16 18:27:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254433004/1
4 years, 4 months ago (2016-08-16 18:30:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 20:27:46 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 20:32:38 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8eaf8ebd391c7f6aae667015a940273a917efa9a
Cr-Commit-Position: refs/heads/master@{#412327}

Powered by Google App Engine
This is Rietveld 408576698