chrome/browser/upgrade_detector_impl.cc - Issue 2254433003: When network time is unavailable, record the reason in UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/upgrade_detector_impl.cc

Issue 2254433003: When network time is unavailable, record the reason in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile failure Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/upgrade_detector_impl.cc

diff --git a/chrome/browser/upgrade_detector_impl.cc b/chrome/browser/upgrade_detector_impl.cc

index cd9668de8fa2ec3d5057eaaf8ea5c1045c8b5b22..cc7e063229806bbc359ce9fdd6d0fc336b169fee 100644

--- a/chrome/browser/upgrade_detector_impl.cc

+++ b/chrome/browser/upgrade_detector_impl.cc

@@ -410,8 +410,9 @@ bool UpgradeDetectorImpl::DetectOutdatedInstall() {

base::Time network_time;

base::TimeDelta uncertainty;

- if (!g_browser_process->network_time_tracker()->GetNetworkTime(

- &network_time, &uncertainty)) {

+ if (g_browser_process->network_time_tracker()->GetNetworkTime(&network_time,

+ &uncertainty) !=

+ network_time::NetworkTimeTracker::NETWORK_TIME_AVAILABLE) {

Lei Zhang 2016/08/18 16:51:19 network time, network time, network time!

// When network time has not been initialized yet, simply rely on the

// machine's current time.

network_time = base::Time::Now();

« no previous file with comments | « no previous file | components/network_time/network_time_tracker.h » ('j') | components/network_time/network_time_tracker.cc » ('J')