Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2254433003: When network time is unavailable, record the reason in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix maximums to not overflow, and fix unit tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/ssl_errors/error_classification.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5e75bd86cff36182036df49127b18dee29d8bb62..8b96eae7e32229f29364db8714835ac8f7fb8dbc 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -20423,6 +20423,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="interstitial.ssl.clockstate.network" enum="ClockStates">
+ <obsolete>
+ Deprecated August 2016. Replaced with interstitial.ssl.clockstate.network2,
+ which records reasons why network time might be unavailable.
+ </obsolete>
+ <owner>mab@chromium.org</owner>
+ <summary>
+ State of the system clock, relative to network time, when an SSL
+ CERT_INVALID_DATE error is seen.
+ </summary>
+</histogram>
+
+<histogram name="interstitial.ssl.clockstate.network2"
+ enum="NetworkClockStates">
+ <owner>estark@chromium.org</owner>
<owner>mab@chromium.org</owner>
<summary>
State of the system clock, relative to network time, when an SSL
@@ -35443,6 +35457,40 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="NetworkTimeTracker.ClockDivergence.Negative" units="seconds">
+ <owner>estark@chromium.org</owner>
+ <owner>mab@chromium.org</owner>
+ <summary>
+ NetworkTimeTracker observes a tick clock and a wall clock to determine
+ whether a timestamp retrieved from the network in the past can be used to
+ compute a current timestamp. When the tick clock and wall clock diverge from
+ each other, the NetworkTimeTracker must discard the network timestamp
+ because it has no way to compute a reliable current timestamp. Whenever the
+ NetworkTimeTracker discards a network timestamp due to the tick and wall
+ clocks diverging, this histogram records the difference of the tick clock's
+ delta minus the wall clock's delta since the network timestamp was
+ retrieved. For cases where the the tick clock delta is bigger than the wall
+ clock delta, see NetworkTimeTracker.ClockDivergence.Positive.
+ </summary>
+</histogram>
+
+<histogram name="NetworkTimeTracker.ClockDivergence.Positive" units="seconds">
+ <owner>estark@chromium.org</owner>
+ <owner>mab@chromium.org</owner>
+ <summary>
+ NetworkTimeTracker observes a tick clock and a wall clock to determine
+ whether a timestamp retrieved from the network in the past can be used to
+ compute a current timestamp. When the tick clock and wall clock diverge from
+ each other, the NetworkTimeTracker must discard the network timestamp
+ because it has no way to compute a reliable current timestamp. Whenever the
+ NetworkTimeTracker discards a network timestamp due to the tick and wall
+ clocks diverging, this histogram records the difference of the tick clock's
+ delta minus the wall clock's delta since the network timestamp was
+ retrieved. For cases where the the wall clock delta is bigger than the tick
+ clock delta, see NetworkTimeTracker.ClockDivergence.Negative.
+ </summary>
+</histogram>
+
<histogram name="NetworkTimeTracker.UpdateTimeFetchAttempted">
<obsolete>
Deprecated 08/2016 because it does not provide additional information beyond
@@ -35479,6 +35527,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="NetworkTimeTracker.WallClockRanBackwards" units="seconds">
+ <owner>estark@chromium.org</owner>
+ <owner>mab@chromium.org</owner>
+ <summary>
+ NetworkTimeTracker observes a tick clock and a wall clock to determine
+ whether a timestamp retrieved from the network in the past can be used to
+ compute a current timestamp. When the NetworkTimeTracker observes that the
+ wall clock ran backwards, the NetworkTimeTracker must discard the network
+ timestamp because it has no way to compute a reliable current timestamp.
+ Whenever the NetworkTimeTracker discards a network timestamp due to the wall
+ clock running backwards, this histogram records the magnitude of the
+ difference of the current wall clock time minus the wall clock time when the
+ network timestamp was retrieved.
+ </summary>
+</histogram>
+
<histogram name="NewTabPage.ActionAndroid" enum="NewTabPageActionAndroid">
<owner>newt@chromium.org</owner>
<summary>
@@ -87198,6 +87262,26 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="42" label="5230"/>
</enum>
+<enum name="NetworkClockStates" type="int">
+ <int value="0"
+ label="NETWORK_CLOCK_STATE_UNKNOWN_NO_SYNC: accuracy of system clock is
+ unknown because there is no information available from the
+ network about what time it is"/>
+ <int value="1"
+ label="NETWORK_CLOCK_STATE_UNKNOWN_SYNC_LOST: system clock is unknown
+ because the system clock has fallen out of sync with the network
+ clock since the last time that network time was retrieved"/>
+ <int value="2"
+ label="NETWORK_CLOCK_STATE_OK: system clock is roughly accurate
+ relative to network time"/>
+ <int value="3"
+ label="NETWORK_CLOCK_STATE_CLOCK_IN_PAST: system clock is in the past
+ relative to network time"/>
+ <int value="4"
+ label="NETWORK_CLOCK_STATE_CLOCK_IN_FUTURE: system clock is in the
+ future relative to network time"/>
+</enum>
+
<enum name="NetworkConnectionIPType" type="int">
<int value="0" label="IPv4"/>
<int value="1" label="IPv6"/>
« no previous file with comments | « components/ssl_errors/error_classification.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698