Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2254433002: Scope analysis: DCHECK that we allocate rest_parameter_ only once. (Closed)

Created:
4 years, 4 months ago by marja
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Scope analysis: DCHECK that we allocate rest_parameter_ only once. BUG=v8:5209 Committed: https://crrev.com/f59c0473312398721b573e1dbe572cc2b7451c8a Cr-Commit-Position: refs/heads/master@{#38673}

Patch Set 1 #

Patch Set 2 : a different dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/ast/scopes.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-17 07:56:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254433002/20001
4 years, 4 months ago (2016-08-17 08:00:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 08:02:17 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 08:02:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f59c0473312398721b573e1dbe572cc2b7451c8a
Cr-Commit-Position: refs/heads/master@{#38673}

Powered by Google App Engine
This is Rietveld 408576698