Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1619)

Unified Diff: third_party/WebKit/Source/core/dom/Range.cpp

Issue 2254423002: boundaryTextInserted/Removed() should not call markValid() for irrelavent changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove useless includes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/RangeTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Range.cpp
diff --git a/third_party/WebKit/Source/core/dom/Range.cpp b/third_party/WebKit/Source/core/dom/Range.cpp
index c2b287b8330d9d4973587d90574795a344301f98..7f1ff8dfd65e10d0ac5e7278a20194cfd156df7f 100644
--- a/third_party/WebKit/Source/core/dom/Range.cpp
+++ b/third_party/WebKit/Source/core/dom/Range.cpp
@@ -1386,9 +1386,9 @@ void Range::nodeWillBeRemoved(Node& node)
static inline void boundaryTextInserted(RangeBoundaryPoint& boundary, Node* text, unsigned offset, unsigned length)
{
- boundary.markValid();
if (boundary.container() != text)
return;
+ boundary.markValid();
unsigned boundaryOffset = boundary.offset();
if (offset >= boundaryOffset)
return;
@@ -1405,9 +1405,9 @@ void Range::didInsertText(Node* text, unsigned offset, unsigned length)
static inline void boundaryTextRemoved(RangeBoundaryPoint& boundary, Node* text, unsigned offset, unsigned length)
{
- boundary.markValid();
if (boundary.container() != text)
return;
+ boundary.markValid();
unsigned boundaryOffset = boundary.offset();
if (offset >= boundaryOffset)
return;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/RangeTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698