Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2254393002:
Reorganize WebGL conformance expectations. (Closed)
|
Created:
4 years, 4 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 4 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, ynovikov Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReorganize WebGL conformance expectations.
A lot of the new Android test expectations went into the "WebGL
extension" part of the expectations file, leading to two sections for
multiple Android devices. Carefully merge these together.
Also collapse some texture-related expectations using wildcards to
improve maintainability and save space.
BUG=490984
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org,cblume@chromium.org
Committed: https://crrev.com/4b445375f64a95a41234aba3a84a44f9cc2b3f57
Cr-Commit-Position: refs/heads/master@{#413590}
Patch Set 1 #Patch Set 2 : Redid from scratch, merging similar entries better. #Patch Set 3 : Minor cleanups. #Messages
Total messages: 17 (10 generated)
Description was changed from ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. BUG=490984 ========== to ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + cblume@chromium.org, zmo@chromium.org
FYI. CQ'ing TBR'd.
Description was changed from ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ==========
Description was changed from ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ========== to ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ==========
CC'ing Yuly as well. Added android_optional_gpu_tests_rel manually.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
Description was changed from ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ========== to ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. Also collapse some texture-related expectations using wildcards to improve maintainability and save space. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. Also collapse some texture-related expectations using wildcards to improve maintainability and save space. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ========== to ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. Also collapse some texture-related expectations using wildcards to improve maintainability and save space. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. Also collapse some texture-related expectations using wildcards to improve maintainability and save space. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org ========== to ========== Reorganize WebGL conformance expectations. A lot of the new Android test expectations went into the "WebGL extension" part of the expectations file, leading to two sections for multiple Android devices. Carefully merge these together. Also collapse some texture-related expectations using wildcards to improve maintainability and save space. BUG=490984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org,cblume@chromium.org Committed: https://crrev.com/4b445375f64a95a41234aba3a84a44f9cc2b3f57 Cr-Commit-Position: refs/heads/master@{#413590} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4b445375f64a95a41234aba3a84a44f9cc2b3f57 Cr-Commit-Position: refs/heads/master@{#413590} |
