Signal extension API schema corruption to the browser process.

extensions/browser/extension_message_filter.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_message_filter.h"
 
 #include "base/macros.h"
 #include "base/memory/singleton.h"
 #include "components/crx_file/id_util.h"
 #include "components/keyed_service/content/browser_context_keyed_service_shutdown_notifier_factory.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "extensions/browser/blob_holder.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/event_router_factory.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/process_manager_factory.h"
 #include "extensions/browser/process_map.h"
 #include "extensions/common/extension.h"
+#include "extensions/common/extension_api.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "ipc/ipc_message_macros.h"
 
 using content::BrowserThread;
 using content::RenderProcessHost;
 
 namespace extensions {
 
 namespace {
@@ skipping 96 matching lines @@
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_RemoveFilteredListener,
                         OnExtensionRemoveFilteredListener)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_ShouldSuspendAck,
                         OnExtensionShouldSuspendAck)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_SuspendAck,
                         OnExtensionSuspendAck)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_TransferBlobsAck,
                         OnExtensionTransferBlobsAck)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_WakeEventPage,
                         OnExtensionWakeEventPage)
+    IPC_MESSAGE_HANDLER(ExtensionHostMsg_NotifyBadExtensionApiSchema,
+                        OnExtensionNotifyBadExtensionApiSchema)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void ExtensionMessageFilter::OnExtensionAddListener(
     const std::string& extension_id,
     const GURL& listener_url,
     const std::string& event_name) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ skipping 164 matching lines @@
 
   // The extension has no background page, so there is nothing to wake.
   SendWakeEventPageResponse(request_id, false);
 }
 
 void ExtensionMessageFilter::SendWakeEventPageResponse(int request_id,
                                                        bool success) {
   Send(new ExtensionMsg_WakeEventPageResponse(request_id, success));
 }
 
+void ExtensionMessageFilter::OnExtensionNotifyBadExtensionApiSchema(
+    const std::string& api) {
+  ExtensionAPI::GetSharedInstance()->LoadSchemaListOrDie(api);

[Devlin, 2016/08/19 18:40:57]

Thinking about it, is there a reason to not just do:
const base::DictionaryValue* schema =
ExetnsionAPI::GetSharedInstance()->LoadSchema(api);
CHECK(schema);
KillBadMessageSender();

That way we wouldn't even need LoadSchemaListOrDie().

[Devlin, 2016/08/19 19:13:27]

(Another advantage to that is that then we don't need to worry about collisions
when we rip out unloaded_schemas)

[Wez, 2016/08/20 01:40:39]

Done.

+}
+
 }  // namespace extensions