Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 2254363003: Support raw types in metadata. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/generic_metadata_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/resolution.dart
diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart
index 73dd7fedc482cb43a4c6beb238665a7e98f88ee1..0f1837d4c1cf6d595b2874835f1a382c5e02e4d3 100644
--- a/pkg/compiler/lib/src/resolution/resolution.dart
+++ b/pkg/compiler/lib/src/resolution/resolution.dart
@@ -1066,7 +1066,8 @@ class ResolverTask extends CompilerTask {
switch (constant.kind) {
case ConstantExpressionKind.CONSTRUCTED:
ConstructedConstantExpression constructedConstant = constant;
- if (constructedConstant.type.isGeneric) {
+ if (constructedConstant.type.isGeneric &&
+ !constructedConstant.type.isRaw) {
// Const constructor calls cannot have type arguments.
// TODO(24312): Remove this.
reporter.reportErrorMessage(
« no previous file with comments | « no previous file | tests/language/generic_metadata_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698