Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 225433003: Add a basic tutorial for the tools in depot_tools. (Closed)

Created:
6 years, 8 months ago by iannucci
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@git_map
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 31

Patch Set 2 : address comments #

Patch Set 3 : address comments #

Patch Set 4 : demo-ize #

Patch Set 5 : Add walkthrough demo #

Patch Set 6 : pylint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4167 lines, -584 lines) Patch
M docs/html/depot_tools.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
A docs/html/depot_tools_tutorial.html View 1 2 3 4 1 chunk +1571 lines, -0 lines 0 comments Download
M docs/html/git-freeze.html View 1 2 3 3 chunks +36 lines, -38 lines 0 comments Download
M docs/html/git-map.html View 1 2 3 3 chunks +25 lines, -22 lines 0 comments Download
M docs/html/git-map-branches.html View 1 2 3 3 chunks +11 lines, -14 lines 0 comments Download
M docs/html/git-mark-merge-base.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M docs/html/git-nav-downstream.html View 1 2 3 3 chunks +33 lines, -26 lines 0 comments Download
M docs/html/git-nav-upstream.html View 1 2 3 3 chunks +40 lines, -22 lines 0 comments Download
M docs/html/git-new-branch.html View 1 2 3 3 chunks +41 lines, -37 lines 0 comments Download
M docs/html/git-rebase-update.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M docs/html/git-rename-branch.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M docs/html/git-reparent-branch.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M docs/html/git-squash-branch.html View 1 2 3 3 chunks +44 lines, -36 lines 0 comments Download
M docs/html/git-thaw.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M docs/html/git-upstream-diff.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M docs/man1/git-freeze.1 View 1 2 3 4 chunks +20 lines, -18 lines 0 comments Download
M docs/man1/git-map.1 View 1 2 3 3 chunks +22 lines, -17 lines 0 comments Download
M docs/man1/git-map-branches.1 View 1 2 3 4 chunks +10 lines, -9 lines 0 comments Download
M docs/man1/git-mark-merge-base.1 View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M docs/man1/git-nav-downstream.1 View 1 2 3 3 chunks +31 lines, -20 lines 0 comments Download
M docs/man1/git-nav-upstream.1 View 1 2 3 4 chunks +35 lines, -14 lines 0 comments Download
M docs/man1/git-new-branch.1 View 1 2 3 4 chunks +36 lines, -19 lines 0 comments Download
M docs/man1/git-rebase-update.1 View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M docs/man1/git-rename-branch.1 View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M docs/man1/git-reparent-branch.1 View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M docs/man1/git-squash-branch.1 View 1 2 3 3 chunks +41 lines, -29 lines 0 comments Download
M docs/man1/git-thaw.1 View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M docs/man1/git-upstream-diff.1 View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M docs/man7/depot_tools.7 View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
A docs/man7/depot_tools_tutorial.7 View 1 2 3 4 1 chunk +1024 lines, -0 lines 0 comments Download
M docs/src/.gitignore View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M docs/src/_footer.txt View 1 chunk +1 line, -1 line 0 comments Download
A docs/src/_helper_prefix.txt View 1 chunk +1 line, -0 lines 0 comments Download
A docs/src/common_demo_functions.sh View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
A docs/src/demo_repo.sh View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A docs/src/depot_tools_tutorial.txt View 1 2 3 4 1 chunk +408 lines, -0 lines 0 comments Download
A docs/src/depot_tools_tutorial.demo.tldr.sh View 1 2 3 4 1 chunk +155 lines, -0 lines 0 comments Download
A docs/src/filter_demo_output.py View 1 2 3 4 5 1 chunk +137 lines, -0 lines 0 comments Download
M docs/src/git-freeze.txt View 1 2 3 1 chunk +1 line, -44 lines 0 comments Download
A docs/src/git-freeze.demo.1.sh View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M docs/src/git-map.txt View 1 2 3 2 chunks +2 lines, -21 lines 0 comments Download
M docs/src/git-map-branches.txt View 1 2 3 2 chunks +2 lines, -13 lines 0 comments Download
A docs/src/git-map-branches.demo.1.sh View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A docs/src/git-map.demo.1.sh View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M docs/src/git-nav-downstream.txt View 1 2 3 1 chunk +1 line, -27 lines 0 comments Download
A docs/src/git-nav-downstream.demo.1.sh View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M docs/src/git-nav-upstream.txt View 1 2 3 1 chunk +3 lines, -21 lines 0 comments Download
A docs/src/git-nav-upstream.demo.1.sh View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M docs/src/git-new-branch.txt View 1 2 3 1 chunk +3 lines, -35 lines 0 comments Download
A docs/src/git-new-branch.demo.1.sh View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M docs/src/git-squash-branch.txt View 1 2 3 1 chunk +1 line, -34 lines 0 comments Download
A docs/src/git-squash-branch.demo.1.sh View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M docs/src/make_docs.sh View 1 2 3 6 chunks +57 lines, -15 lines 0 comments Download
A docs/src/prep_demo_repo.sh View 1 2 3 4 1 chunk +103 lines, -0 lines 0 comments Download
M git_common.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M git_nav_downstream.py View 1 2 3 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
iannucci
6 years, 8 months ago (2014-04-04 08:45:32 UTC) #1
iannucci
On 2014/04/04 08:45:32, iannucci wrote: PTAL. The relevant changes are in `docs/src/depot_tools_tutorial.txt`
6 years, 8 months ago (2014-04-04 17:24:28 UTC) #2
iannucci
+cmp if interested (relevant text in docs/src/depot_tools_tutorial.txt)
6 years, 8 months ago (2014-04-04 18:55:24 UTC) #3
agable
nit below. Also, don't reference "I" -- the author of the doc should be invisible. ...
6 years, 8 months ago (2014-04-04 23:18:58 UTC) #4
iannucci
On 2014/04/04 23:18:58, agable wrote: > nit below. Also, don't reference "I" -- the author ...
6 years, 8 months ago (2014-04-04 23:22:04 UTC) #5
agable
Threw some more specific comments in. Sorry I'm sucking all the humor out of the ...
6 years, 8 months ago (2014-04-04 23:34:11 UTC) #6
Ryan Tseng
https://codereview.chromium.org/225433003/diff/1/docs/src/depot_tools_tutorial.txt File docs/src/depot_tools_tutorial.txt (right): https://codereview.chromium.org/225433003/diff/1/docs/src/depot_tools_tutorial.txt#newcode38 docs/src/depot_tools_tutorial.txt:38: * link:http://git-scm.com/book[Pro Git book] - Pretty good overview of ...
6 years, 8 months ago (2014-04-05 00:51:20 UTC) #7
iannucci
PTAL https://codereview.chromium.org/225433003/diff/1/docs/src/depot_tools_tutorial.txt File docs/src/depot_tools_tutorial.txt (right): https://codereview.chromium.org/225433003/diff/1/docs/src/depot_tools_tutorial.txt#newcode14 docs/src/depot_tools_tutorial.txt:14: Chromium codebase expertly. This tutorial explains how to ...
6 years, 8 months ago (2014-04-05 01:31:13 UTC) #8
iannucci
I'm landing this as-is, and I'll request feedback from you all on the rendered content. ...
6 years, 8 months ago (2014-04-11 04:41:10 UTC) #9
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 8 months ago (2014-04-11 04:46:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/225433003/80001
6 years, 8 months ago (2014-04-11 04:46:20 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 04:48:08 UTC) #12
commit-bot: I haz the power
Presubmit check for 225433003-80001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-11 04:48:08 UTC) #13
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 8 months ago (2014-04-11 04:49:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/225433003/100001
6 years, 8 months ago (2014-04-11 04:49:38 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 04:51:51 UTC) #16
Message was sent while issue was closed.
Change committed as 263164

Powered by Google App Engine
This is Rietveld 408576698