Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analyzer/test/source/embedder_test.dart

Issue 2254313002: Extract EmbedderRelatedTest to a utility file (Closed) Base URL: git@github.com:cbracken/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/embedder_tests.dart ('k') | pkg/analyzer/test/src/context/builder_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/source/embedder_test.dart
diff --git a/pkg/analyzer/test/source/embedder_test.dart b/pkg/analyzer/test/source/embedder_test.dart
index ea20cd728db736b7a348b60b2a744a08535b3906..18448e7afbe8c50445851506b56e6b6e67f4a6b2 100644
--- a/pkg/analyzer/test/source/embedder_test.dart
+++ b/pkg/analyzer/test/source/embedder_test.dart
@@ -6,17 +6,14 @@ library analyzer.test.source.embedder_test;
import 'dart:core' hide Resource;
-import 'package:analyzer/file_system/file_system.dart';
-import 'package:analyzer/file_system/memory_file_system.dart';
import 'package:analyzer/source/embedder.dart';
import 'package:analyzer/src/generated/sdk.dart';
import 'package:analyzer/src/generated/source.dart';
-import 'package:path/path.dart' as path;
import 'package:unittest/unittest.dart';
+import '../embedder_tests.dart';
import '../reflective_tests.dart';
import '../resource_utils.dart';
-import '../utils.dart';
main() {
runReflectiveTests(DartUriResolverTest);
@@ -48,46 +45,6 @@ class DartUriResolverTest extends EmbedderRelatedTest {
}
}
-abstract class EmbedderRelatedTest {
- TestPathTranslator pathTranslator;
- ResourceProvider resourceProvider;
-
- buildResourceProvider() {
- MemoryResourceProvider rawProvider =
- new MemoryResourceProvider(isWindows: isWindows);
- resourceProvider = new TestResourceProvider(rawProvider);
- pathTranslator = new TestPathTranslator(rawProvider)
- ..newFolder('/empty')
- ..newFolder('/tmp')
- ..newFile(
- '/tmp/_embedder.yaml',
- r'''
-embedded_libs:
- "dart:core" : "core.dart"
- "dart:fox": "slippy.dart"
- "dart:bear": "grizzly.dart"
- "dart:relative": "../relative.dart"
- "dart:deep": "deep/directory/file.dart"
- "fart:loudly": "nomatter.dart"
-''');
- }
-
- clearResourceProvider() {
- resourceProvider = null;
- pathTranslator = null;
- }
-
- void setUp() {
- initializeTestEnvironment(path.context);
- buildResourceProvider();
- }
-
- void tearDown() {
- initializeTestEnvironment();
- clearResourceProvider();
- }
-}
-
@reflectiveTest
class EmbedderSdkTest extends EmbedderRelatedTest {
void test_creation() {
« no previous file with comments | « pkg/analyzer/test/embedder_tests.dart ('k') | pkg/analyzer/test/src/context/builder_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698