Issue 2254313002: Extract EmbedderRelatedTest to a utility file

Issue 2254313002: Extract EmbedderRelatedTest to a utility file (Closed)

Created:
4 years, 4 months ago by Chris Bracken

Modified:
4 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:cbracken/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Extract EmbedderRelatedTest to a utility file This avoids importing all the embedder_test tests for tests where only EmbedderRelatedTest is required. It also simplifies automatically globbing utility code vs tests. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8e35cbf413a25814bf3ebb4aea945a66156139a5 Committed: https://github.com/dart-lang/sdk/commit/5a936f26eae7d83a9b050723867759af8df4f1d2

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -46 lines)			Patch
A	pkg/analyzer/test/embedder_tests.dart	View	1 chunk	+54 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/source/embedder_test.dart	View	2 chunks	+1 line, -44 lines	0 comments	Download
M	pkg/analyzer/test/src/context/builder_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/src/dart/sdk/sdk_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Chris Bracken

Committed patchset #1 (id:1) manually as 8e35cbf413a25814bf3ebb4aea945a66156139a5 (presubmit successful).

4 years, 4 months ago (2016-08-18 20:36:05 UTC) #4

Chris Bracken

4 years, 4 months ago (2016-08-18 20:38:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5a936f26eae7d83a9b050723867759af8df4f1d2 (presubmit successful).