Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2254303005: Don't schedule a wake-up if the timeline hasn't started (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 4 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@smilcontainer-timeline-cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't schedule a wake-up if the timeline hasn't started Before the timeline has started we shouldn't update animations. This makes resume() symmetric with pause(). BUG=631879 Committed: https://crrev.com/74765e5a1cda876448a6b44c23c3a9e20e59f53d Cr-Commit-Position: refs/heads/master@{#413336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
fs
4 years, 4 months ago (2016-08-19 13:26:23 UTC) #4
pdr.
On 2016/08/19 at 13:26:23, fs wrote: > Super clean. LGTM
4 years, 4 months ago (2016-08-19 21:43:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254303005/1
4 years, 4 months ago (2016-08-20 13:08:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 14:28:19 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 14:30:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74765e5a1cda876448a6b44c23c3a9e20e59f53d
Cr-Commit-Position: refs/heads/master@{#413336}

Powered by Google App Engine
This is Rietveld 408576698