Move GLImageOzoneNativePixmap tests to src/ui/ozone.

Move GLImageOzoneNativePixmap tests to src/ui/ozone.

GLImageOzoneNativePixmap was previously moved from //ui/gl to
//ui/ozone/gl. The related tests were not moved at the same time. This
CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests.

The exists ozone_unittests target does not have an appropriate TestSuite
for running GL tests, so a different target is required. The existing
TestSuite for GL tests is placed in a source_set so it can be used by
both gl_unittests and ozone_gl_unittests.

Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot.
Finally, remove some unneeded DEPS rules now that the tests have been
moved.

BUG=611142
Committed: https://crrev.com/4fab9214930cb13623ecd24aea0381e07c1a333c
Cr-Commit-Position: refs/heads/master@{#414145}

[kylechar, 2016-08-18 20:38:12]

Description was changed from

==========
Move GLImageOzoneNativePixmap tests to src/ui/ozone.

GLImageOzoneNativePixmap was previously moved from //ui/gl to
//ui/ozone/gl. The related tests were not moved at the same time. This
CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests.

The exists ozone_unittests target does not have an appropriate TestSuite
for running GL tests, so a different target is required. The existing
TestSuite for GL tests is placed in a source_set so it can be used by
both gl_unittests and ozone_gl_unittests.

Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot.
Finally, remove some unneeded DEPS rules now that the tests have been
moved.

BUG=611142
==========

to

==========
Move GLImageOzoneNativePixmap tests to src/ui/ozone.

GLImageOzoneNativePixmap was previously moved from //ui/gl to
//ui/ozone/gl. The related tests were not moved at the same time. This
CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests.

The exists ozone_unittests target does not have an appropriate TestSuite
for running GL tests, so a different target is required. The existing
TestSuite for GL tests is placed in a source_set so it can be used by
both gl_unittests and ozone_gl_unittests.

Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot.
Finally, remove some unneeded DEPS rules now that the tests have been
moved.

BUG=611142
==========

[kylechar, 2016-08-18 20:38:12]

kylechar@chromium.org changed reviewers:
+ kbr@chromium.org, rjkroege@chromium.org

[Ken Russell (switch to Gerrit), 2016-08-20 02:51:43]

LGTM mainly given that the tests are passing.

dpranke@ is the best reviewer for changes to gn_isolate_map.pyl, but since the
change is tested by your tryjob, and since it's so trivial, I'm comfortable
reviewing it.

https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
File testing/buildbot/gn_isolate_map.pyl (right):

https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
testing/buildbot/gn_isolate_map.pyl:507: "type": "raw",
Is this type correct? I do see it's used by other graphics tests in this file.

[Ken Russell (switch to Gerrit), 2016-08-20 02:58:48]

BTW -- Issue 611142 is marked fixed. Either it should be marked "Started" again
or another bug should be filed, blocked on Issue 611142, and this CL should
reference that one. In general, CLs shouldn't be committed against fixed bugs.

[kylechar, 2016-08-22 14:50:17]

kylechar@chromium.org changed reviewers:
+ dpranke@chromium.org

[kylechar, 2016-08-22 14:50:17]

+dpranke for lgtm/context on the gn_isoalte_map.pyl question. I'm not sure why
it uses type raw, I was just using the same setup as the existing gl_unittests
target.

Thanks kbr! I've reopened the bug as well. This is cleanup related to the
original refactor so it's best to be included in the same bug.

https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
File testing/buildbot/gn_isolate_map.pyl (right):

https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
testing/buildbot/gn_isolate_map.pyl:507: "type": "raw",
On 2016/08/20 02:51:43, Ken Russell wrote:
> Is this type correct? I do see it's used by other graphics tests in this file.

I just used the same setup as gl_unittests so unfortunately I don't know why
graphics unit tests all use type raw.

Maybe dpranke has some more insight?

[Dirk Pranke, 2016-08-22 17:30:38]

On 2016/08/22 14:50:17, kylechar wrote:
> +dpranke for lgtm/context on the gn_isoalte_map.pyl question. I'm not sure why
> it uses type raw, I was just using the same setup as the existing gl_unittests
> target.
> 
> Thanks kbr! I've reopened the bug as well. This is cleanup related to the
> original refactor so it's best to be included in the same bug.
> 
>
https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
> File testing/buildbot/gn_isolate_map.pyl (right):
> 
>
https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
> testing/buildbot/gn_isolate_map.pyl:507: "type": "raw",
> On 2016/08/20 02:51:43, Ken Russell wrote:
> > Is this type correct? I do see it's used by other graphics tests in this
file.
> 
> I just used the same setup as gl_unittests so unfortunately I don't know why
> graphics unit tests all use type raw.
> 
> Maybe dpranke has some more insight?

'raw' largely means that the command should be run with no extra args. In
particular, it means that we
don't use test_env.py, and don't pass the //base/test/launcher args like
--brave-new-test-launcher --test-launcher-bot-mode.

Generally speaking, most of our test binaries should be using the
//base/test/launcher scaffolding.

[kylechar, 2016-08-23 18:25:58]

On 2016/08/22 17:30:38, Dirk Pranke wrote:
> On 2016/08/22 14:50:17, kylechar wrote:
> > +dpranke for lgtm/context on the gn_isoalte_map.pyl question. I'm not sure
why
> > it uses type raw, I was just using the same setup as the existing
gl_unittests
> > target.
> > 
> > Thanks kbr! I've reopened the bug as well. This is cleanup related to the
> > original refactor so it's best to be included in the same bug.
> > 
> >
>
https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
> > File testing/buildbot/gn_isolate_map.pyl (right):
> > 
> >
>
https://codereview.chromium.org/2254303002/diff/40001/testing/buildbot/gn_iso...
> > testing/buildbot/gn_isolate_map.pyl:507: "type": "raw",
> > On 2016/08/20 02:51:43, Ken Russell wrote:
> > > Is this type correct? I do see it's used by other graphics tests in this
> file.
> > 
> > I just used the same setup as gl_unittests so unfortunately I don't know why
> > graphics unit tests all use type raw.
> > 
> > Maybe dpranke has some more insight?
> 
> 'raw' largely means that the command should be run with no extra args. In
> particular, it means that we
> don't use test_env.py, and don't pass the //base/test/launcher args like
> --brave-new-test-launcher --test-launcher-bot-mode.
> 
> Generally speaking, most of our test binaries should be using the
> //base/test/launcher scaffolding.

Ah, well it runs fine as a console_test, so I'll leave it as that instead.

[kylechar, 2016-08-24 13:28:30]

Whoops, forgot to mention rjkroege for ui/ozone/*.

[rjkroege, 2016-08-24 19:05:53]

lgtm

[kylechar, 2016-08-24 19:14:26]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 19:15:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:00:17]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-08-24 21:00:41]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-08-24 21:00:41]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2254303002/#ps60001
(title: "Try as console test.")

[commit-bot: I haz the power, 2016-08-24 21:02:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:09:27]

Description was changed from

==========
Move GLImageOzoneNativePixmap tests to src/ui/ozone.

GLImageOzoneNativePixmap was previously moved from //ui/gl to
//ui/ozone/gl. The related tests were not moved at the same time. This
CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests.

The exists ozone_unittests target does not have an appropriate TestSuite
for running GL tests, so a different target is required. The existing
TestSuite for GL tests is placed in a source_set so it can be used by
both gl_unittests and ozone_gl_unittests.

Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot.
Finally, remove some unneeded DEPS rules now that the tests have been
moved.

BUG=611142
==========

to

==========
Move GLImageOzoneNativePixmap tests to src/ui/ozone.

GLImageOzoneNativePixmap was previously moved from //ui/gl to
//ui/ozone/gl. The related tests were not moved at the same time. This
CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests.

The exists ozone_unittests target does not have an appropriate TestSuite
for running GL tests, so a different target is required. The existing
TestSuite for GL tests is placed in a source_set so it can be used by
both gl_unittests and ozone_gl_unittests.

Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot.
Finally, remove some unneeded DEPS rules now that the tests have been
moved.

BUG=611142
==========

[commit-bot: I haz the power, 2016-08-24 21:09:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 21:10:42]

Description was changed from

==========
Move GLImageOzoneNativePixmap tests to src/ui/ozone.

GLImageOzoneNativePixmap was previously moved from //ui/gl to
//ui/ozone/gl. The related tests were not moved at the same time. This
CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests.

The exists ozone_unittests target does not have an appropriate TestSuite
for running GL tests, so a different target is required. The existing
TestSuite for GL tests is placed in a source_set so it can be used by
both gl_unittests and ozone_gl_unittests.

Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot.
Finally, remove some unneeded DEPS rules now that the tests have been
moved.

BUG=611142
==========

to

==========
Move GLImageOzoneNativePixmap tests to src/ui/ozone.

GLImageOzoneNativePixmap was previously moved from //ui/gl to
//ui/ozone/gl. The related tests were not moved at the same time. This
CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests.

The exists ozone_unittests target does not have an appropriate TestSuite
for running GL tests, so a different target is required. The existing
TestSuite for GL tests is placed in a source_set so it can be used by
both gl_unittests and ozone_gl_unittests.

Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot.
Finally, remove some unneeded DEPS rules now that the tests have been
moved.

BUG=611142

Committed: https://crrev.com/4fab9214930cb13623ecd24aea0381e07c1a333c
Cr-Commit-Position: refs/heads/master@{#414145}
==========

[commit-bot: I haz the power, 2016-08-24 21:10:46]

Patchset 4 (id:??) landed as
https://crrev.com/4fab9214930cb13623ecd24aea0381e07c1a333c
Cr-Commit-Position: refs/heads/master@{#414145}