Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2254293002:
Allow 2D canvases to be GPU accelerated on linux (Closed)
|
Created:
4 years, 4 months ago by Justin Novosad Modified:
4 years, 4 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow 2D canvases to be GPU accelerated on linux
Removing an old gpu blacklist entry that disabled GPU acceleration of
2D canvases on linux. The decision at the time was motivated by the
fact that a larger number of linux drivers were unstable and that GL
contexts would get dropped under heavy resource strain. Since that
time, buggy drivers have been identified, and there are other
blacklist entries that disable all GPU features when those drivers
are detected, and Chrome does a better job of avoiding GPU resource
strain from canvas backings.
BUG=639024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/15dd1c2199030d52529b74f2a13decdc3c60cdd1
Cr-Commit-Position: refs/heads/master@{#412920}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
Description was changed from ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux driveris were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 ========== to ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux driveris were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
junov@chromium.org changed reviewers: + senorblanco@google.com
The CQ bit was checked by junov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux driveris were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux drivers were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
junov@chromium.org changed reviewers: + kbr@chromium.org - senorblanco@google.com
Changing reviewer to kbr (senorblanco is not an owner)
piman@chromium.org changed reviewers: + piman@chromium.org
lgtm
The CQ bit was unchecked by junov@chromium.org
The CQ bit was checked by junov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux drivers were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux drivers were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
LGTM too.
Message was sent while issue was closed.
Description was changed from ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux drivers were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Allow 2D canvases to be GPU accelerated on linux Removing an old gpu blacklist entry that disabled GPU acceleration of 2D canvases on linux. The decision at the time was motivated by the fact that a larger number of linux drivers were unstable and that GL contexts would get dropped under heavy resource strain. Since that time, buggy drivers have been identified, and there are other blacklist entries that disable all GPU features when those drivers are detected, and Chrome does a better job of avoiding GPU resource strain from canvas backings. BUG=639024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/15dd1c2199030d52529b74f2a13decdc3c60cdd1 Cr-Commit-Position: refs/heads/master@{#412920} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/15dd1c2199030d52529b74f2a13decdc3c60cdd1 Cr-Commit-Position: refs/heads/master@{#412920} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
