Remove text encoding UI

chrome/browser/character_encoding.h

Index: chrome/browser/character_encoding.h
diff --git a/chrome/browser/character_encoding.h b/chrome/browser/character_encoding.h
index 2c70a178dd7f2a2d4180ff3ca604ad9d04784740..4168e5662773ba9f167a53785464d7b04472b55e 100644
--- a/chrome/browser/character_encoding.h
+++ b/chrome/browser/character_encoding.h
@@ -44,24 +44,6 @@ class CharacterEncoding {
   // only in UI thread.
   static base::string16 GetCanonicalEncodingDisplayNameByCommandId(int id);
 
-  // Return count number of all supported canonical encoding.
-  static int GetSupportCanonicalEncodingCount();
-
-  // Return canonical encoding name according to the index, which starts
-  // from zero to GetSupportCanonicalEncodingCount() - 1. THIS FUNCTION
-  // IS NOT THREADSAFE. You must run this function only in UI thread.
-  static std::string GetCanonicalEncodingNameByIndex(int index);
-
-  // Return display name of canonical encoding according to the index,
-  // which starts from zero to GetSupportCanonicalEncodingCount() - 1.
-  // THIS FUNCTION IS NOT THREADSAFE. You must run this function
-  // only in UI thread.
-  static base::string16 GetCanonicalEncodingDisplayNameByIndex(int index);
-
-  // Return encoding command id according to the index, which starts from
-  // zero to GetSupportCanonicalEncodingCount() - 1. Otherwise returns 0.
-  static int GetEncodingCommandIdByIndex(int index);
-
   // Return canonical encoding name according to the encoding alias name. THIS
   // FUNCTION IS NOT THREADSAFE. You must run this function only in UI thread.

[msw, 2016/08/23 18:06:27]

q: Is this no longer relevant?

[Jinsuk Kim, 2016/08/23 22:46:13]

That was necessary because |CanonicalEncodingMap| singleton was not threadsafe.
Now it's gone and it uses a const array only.

And I hope the linear search is okay since the array size is small.

   static std::string GetCanonicalEncodingNameByAliasName(
@@ -84,15 +66,6 @@ class CharacterEncoding {
       const std::string& locale_encodings,
       const std::string& recently_select_encodings);
 
-  // This function is for updating |original_selected_encoding_list| with a
-  // |new_selected_encoding_id|. If the encoding is already in the original
-  // list, then returns false. Otherwise |selected_encoding_list| will return a
-  // new string for user selected encoding short list and function returns true.
-  static bool UpdateRecentlySelectedEncoding(
-      const std::string& original_selected_encodings,
-      int new_selected_encoding_id,
-      std::string* selected_encodings);
-
   // Get encoding command id according to input encoding name. If the name is
   // valid, return corresponding encoding command id. Otherwise return 0;
   static int GetCommandIdByCanonicalEncodingName(