Remove text encoding UI

chrome/browser/browser_encoding_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "build/build_config.h"
-#include "chrome/browser/character_encoding.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 152 matching lines @@
   ui_test_utils::NavigateToURL(browser(), url);
   EXPECT_EQ(GetParam().encoding_name,
             browser()->tab_strip_model()->GetActiveWebContents()->
                 GetEncoding());
 }
 
 INSTANTIATE_TEST_CASE_P(EncodingAliases,
                         BrowserEncodingTest,
                         testing::ValuesIn(kEncodingTestDatas));
 
-// Marked as flaky: see  http://crbug.com/44668
-IN_PROC_BROWSER_TEST_F(BrowserEncodingTest, DISABLED_TestOverrideEncoding) {
-  const char* const kTestFileName = "gb18030_with_iso88591_meta.html";
-  const char* const kExpectedFileName =
-      "expected_gb18030_saved_from_iso88591_meta.html";
-  const char* const kOverrideTestDir = "user_override";
-
-  base::FilePath test_dir_path =
-      base::FilePath(kTestDir).AppendASCII(kOverrideTestDir);
-  test_dir_path = test_dir_path.AppendASCII(kTestFileName);
-  GURL url =
-      net::URLRequestMockHTTPJob::GetMockUrl(test_dir_path.MaybeAsASCII());
-  ui_test_utils::NavigateToURL(browser(), url);
-  content::WebContents* web_contents =
-      browser()->tab_strip_model()->GetActiveWebContents();
-  EXPECT_EQ("windows-1252", web_contents->GetEncoding());
-
-  // Override the encoding to "gb18030".
-  const std::string selected_encoding =
-      CharacterEncoding::GetCanonicalEncodingNameByAliasName("gb18030");
-  content::TestNavigationObserver navigation_observer(web_contents);
-  web_contents->SetOverrideEncoding(selected_encoding);
-  navigation_observer.Wait();
-  EXPECT_EQ("gb18030", web_contents->GetEncoding());
-
-  base::FilePath expected_filename =
-      base::FilePath().AppendASCII(kOverrideTestDir).AppendASCII(
-          kExpectedFileName);
-  SaveAndCompare(kTestFileName, expected_filename);
-}
-
 // The following encodings are excluded from the auto-detection test because
 // it's a known issue that the current encoding detector does not detect them:
 // ISO-8859-4
 // ISO-8859-13
 // KOI8-U
 // macintosh
 // windows-874
 // windows-1252
 // windows-1253
 // windows-1257
@@ skipping 73 matching lines @@
 
   // Set the default charset to one of encodings not supported by the current
   // auto-detector (Please refer to the above comments) to make sure we
   // incorrectly decode the page. Now we use ISO-8859-4.
   browser()->profile()->GetPrefs()->SetString(prefs::kDefaultCharset,
                                               "ISO-8859-4");
 
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   for (size_t i = 0; i < arraysize(kTestDatas); ++i) {
-    // Disable auto detect if it is on.
+    // Enable auto detect.
     browser()->profile()->GetPrefs()->SetBoolean(
-        prefs::kWebKitUsesUniversalDetector, false);
+        prefs::kWebKitUsesUniversalDetector, true);
 
     base::FilePath test_file_path(test_dir_path);
     test_file_path = test_file_path.AppendASCII(kTestDatas[i].test_file_name);
     GURL url =
         net::URLRequestMockHTTPJob::GetMockUrl(test_file_path.MaybeAsASCII());
     ui_test_utils::NavigateToURL(browser(), url);
 
-    // Get the encoding used for the page, it must be the default charset we
-    // just set.
-    EXPECT_EQ("ISO-8859-4", web_contents->GetEncoding());
-
-    // Enable the encoding auto detection.
-    browser()->profile()->GetPrefs()->SetBoolean(
-        prefs::kWebKitUsesUniversalDetector, true);
-
-    content::TestNavigationObserver observer(web_contents);
-    chrome::Reload(browser(), CURRENT_TAB);
-    observer.Wait();
-
-    // Re-get the encoding of page. It should return the real encoding now.
+    // Get the encoding of page. It should return the real encoding now.
     EXPECT_EQ(kTestDatas[i].expected_encoding, web_contents->GetEncoding());
 
     // Dump the page, the content of dump page should be equal with our expect
     // result file.
     base::FilePath expected_result_file_name =
         base::FilePath().AppendASCII(kAutoDetectDir).
         AppendASCII(kExpectedResultDir).
         AppendASCII(kTestDatas[i].expected_result);
     SaveAndCompare(kTestDatas[i].test_file_name, expected_result_file_name);
   }
 }