Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2254223002: Fix touch event parameter order (Closed)

Created:
4 years, 4 months ago by liyuqian
Modified:
4 years, 4 months ago
Reviewers:
jvanverth1, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix touch event parameter order The issue is so obvious... However, all newer Android devices (e.g., Nexus 6P, 5X, 9) are immune to this bug. So I didn't notice this until I tested Viewer app on Nexus 7 yesterday... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254223002 Committed: https://skia.googlesource.com/skia/+/23d24587ee4907ebb8136abe177721ca51b5a89a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/viewer/sk_app/android/surface_glue_android.cpp View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
liyuqian
4 years, 4 months ago (2016-08-18 17:04:44 UTC) #4
djsollen
lgtm
4 years, 4 months ago (2016-08-22 16:09:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254223002/1
4 years, 4 months ago (2016-08-22 17:58:42 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:31:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/23d24587ee4907ebb8136abe177721ca51b5a89a

Powered by Google App Engine
This is Rietveld 408576698