analyzer_exp fixes

pkg/analyzer_experimental/lib/src/services/writer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library source_writer;
 
 
 class Line {
 
   final int lineLength;
   final tokens = <LineToken>[];
   final bool useTabs;
   final int spacesPerIndent;
 
   Line({indent: 0, this.lineLength: 80, this.useTabs: false,
         this.spacesPerIndent: 2}) {
     if (indent > 0) {
       _indent(indent);
     }
   }
 
-  addSpace() {
+  void addSpace() {

[pquitslund, 2013/08/08 21:20:23]

Again, why be explicit here?  Like I said, I prefer to be terse where possible
and since this isn't mean to be API I'm not sure what's gained from the explicit
return.

Having said that, I'm keen to get your 2 cents!

     addSpaces(1);
   }
 
-  addSpaces(int n) {
+  void addSpaces(int n) {

[pquitslund, 2013/08/08 21:20:23]

Ditto.

     if (n > 0) {
       tokens.add(new SpaceToken(n));
     }
   }
 
-  addToken(LineToken token) {
+  void addToken(LineToken token) {

[pquitslund, 2013/08/08 21:20:23]

Ditto.

     tokens.add(token);
   }
 
-  bool isWhitespace() {
-    for (var tok in tokens) {
-      if (!(tok is SpaceToken)) {
-        return false;
-      }
-    }
-    return true;
-  }
+  bool isWhitespace() => tokens.every((tok) => tok is SpaceToken);

[pquitslund, 2013/08/08 21:20:23]

Sweet!

 
-  _indent(int n) {
+  void _indent(int n) {

[pquitslund, 2013/08/08 21:20:23]

Ditto.  (And for the rest too.)

     tokens.add(useTabs ? new TabToken(n) : new SpaceToken(n * spacesPerIndent));
   }
 
   String toString() {
     var buffer = new StringBuffer();
     for (var tok in tokens) {
       buffer.write(tok.toString());
     }
     return buffer.toString();
   }
@@ skipping 33 matching lines @@
   final StringBuffer buffer = new StringBuffer();
   Line currentLine;
 
   final String lineSeparator;
   int indentCount = 0;
 
   SourceWriter({this.indentCount: 0, this.lineSeparator: '\n'}) {
     currentLine = new Line(indent: indentCount);
   }
 
-  indent() {
+  void indent() {
     ++indentCount;
   }
 
-  unindent() {
+  void unindent() {
     --indentCount;
   }
 
-  print(x) {
+  void print(x) {
     currentLine.addToken(new LineToken(x));
   }
 
-  newline() {
+  void newline() {
     if (currentLine.isWhitespace()) {
       currentLine.tokens.clear();
     }
     currentLine.addToken(new NewlineToken(this.lineSeparator));
     buffer.write(currentLine.toString());
     currentLine = new Line(indent: indentCount);
   }
 
-  newlines(int num) {
+  void newlines(int num) {
     while (num-- > 0) {
       newline();
     }
   }
 
-  space() {
+  void space() {
     spaces(1);
   }
 
-  spaces(n) {
+  void spaces(n) {
     currentLine.addSpaces(n);
   }
 
-  println(String s) {
+  void println(String s) {
     print(s);
     newline();
   }
 
   String toString() {
     var source = new StringBuffer(buffer.toString());
     if (!currentLine.isWhitespace()) {
       source.write(currentLine);
     }
     return source.toString();
   }
 
 }
 
 
 const SPACE = ' ';
-final SPACES = [
+const SPACES = const [
           '',
           ' ',
           '  ',
           '   ',
           '    ',
           '     ',
           '      ',
           '       ',
           '        ',
           '         ',
           '          ',
           '           ',
           '            ',
           '             ',
           '              ',
           '               ',
           '                ',
 ];
-final TABS = [
+const TABS = const [
           '',
           '\t',
           '\t\t',
           '\t\t\t',
           '\t\t\t\t',
           '\t\t\t\t\t',
           '\t\t\t\t\t\t',
           '\t\t\t\t\t\t\t',
           '\t\t\t\t\t\t\t\t',
           '\t\t\t\t\t\t\t\t\t',
@@ skipping 12 matching lines @@
 
 String getTabs(int n) => n < TABS.length ? TABS[n] : repeat('\t', n);
 
 String repeat(String ch, int times) {
   var sb = new StringBuffer();
   for (var i = 0; i < times; ++i) {
     sb.write(ch);
   }
   return sb.toString();
 }