Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2254193002: Explicitly initialize Code::builtin_index (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Explicitly initialize Code::builtin_index Initialize Code::builtin_index to -1. This ensures that it is non-negative for builtin code objects (since it is set by Builtins::SetUp), and -1 for everything else. BUG= Committed: https://crrev.com/116667f73e93fc1cdbcff101cbdc3b518110b905 Cr-Commit-Position: refs/heads/master@{#38719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 4 months ago (2016-08-18 12:52:16 UTC) #4
Jarin
lgtm
4 years, 4 months ago (2016-08-18 14:16:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254193002/1
4 years, 4 months ago (2016-08-18 14:27:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 14:34:06 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 14:34:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/116667f73e93fc1cdbcff101cbdc3b518110b905
Cr-Commit-Position: refs/heads/master@{#38719}

Powered by Google App Engine
This is Rietveld 408576698