Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2254173003: De-dupe MD Settings localized strings (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

De-dupe MD Settings localized strings R=stevenjb@chromium.org Committed: https://crrev.com/c09c6c482ad9962c96d66d4f8163c9913fc7d3f5 Cr-Commit-Position: refs/heads/master@{#413468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
michaelpg
4 years, 4 months ago (2016-08-19 05:28:53 UTC) #3
stevenjb
lgtm
4 years, 4 months ago (2016-08-22 16:50:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254173003/1
4 years, 4 months ago (2016-08-22 16:51:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 17:36:52 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:38:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c09c6c482ad9962c96d66d4f8163c9913fc7d3f5
Cr-Commit-Position: refs/heads/master@{#413468}

Powered by Google App Engine
This is Rietveld 408576698