Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: content/child/shared_memory_data_consumer_handle_unittest.cc

Issue 2254173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/shared_memory_data_consumer_handle_unittest.cc
diff --git a/content/child/shared_memory_data_consumer_handle_unittest.cc b/content/child/shared_memory_data_consumer_handle_unittest.cc
index fae896cf12acec41cdce3c5e1148d6ca0e092f90..7acbb9a52335180ebac2b51c6b4d040dd771195d 100644
--- a/content/child/shared_memory_data_consumer_handle_unittest.cc
+++ b/content/child/shared_memory_data_consumer_handle_unittest.cc
@@ -203,7 +203,7 @@ class SharedMemoryDataConsumerHandleTest
}
std::unique_ptr<FixedReceivedData> NewFixedData(const char* s) {
auto size = strlen(s);
- return base::WrapUnique(new FixedReceivedData(s, size, size, size));
+ return base::MakeUnique<FixedReceivedData>(s, size, size, size);
}
StrictMock<MockClient> client_;
@@ -907,17 +907,17 @@ TEST(SharedMemoryDataConsumerHandleBackpressureTest, Read) {
size_t size;
std::unique_ptr<Writer> writer;
- auto handle = base::WrapUnique(
- new SharedMemoryDataConsumerHandle(kApplyBackpressure, &writer));
+ auto handle = base::MakeUnique<SharedMemoryDataConsumerHandle>(
+ kApplyBackpressure, &writer);
scoped_refptr<Logger> logger(new Logger);
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data1", "Once ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data1", "Once ", logger));
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data2", "upon ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data2", "upon ", logger));
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data3", "a ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data3", "a ", logger));
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data4", "time ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data4", "time ", logger));
auto reader = handle->obtainReader(nullptr);
logger->Add("1");
@@ -952,15 +952,15 @@ TEST(SharedMemoryDataConsumerHandleBackpressureTest, CloseAndReset) {
size_t size;
std::unique_ptr<Writer> writer;
- auto handle = base::WrapUnique(
- new SharedMemoryDataConsumerHandle(kApplyBackpressure, &writer));
+ auto handle = base::MakeUnique<SharedMemoryDataConsumerHandle>(
+ kApplyBackpressure, &writer);
scoped_refptr<Logger> logger(new Logger);
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data1", "Once ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data1", "Once ", logger));
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data2", "upon ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data2", "upon ", logger));
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data3", "a ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data3", "a ", logger));
auto reader = handle->obtainReader(nullptr);
logger->Add("1");
@@ -988,16 +988,16 @@ TEST(SharedMemoryDataConsumerHandleBackpressureTest, CloseAndReset) {
TEST(SharedMemoryDataConsumerHandleWithoutBackpressureTest, AddData) {
base::MessageLoop loop;
std::unique_ptr<Writer> writer;
- auto handle = base::WrapUnique(
- new SharedMemoryDataConsumerHandle(kDoNotApplyBackpressure, &writer));
+ auto handle = base::MakeUnique<SharedMemoryDataConsumerHandle>(
+ kDoNotApplyBackpressure, &writer);
scoped_refptr<Logger> logger(new Logger);
logger->Add("1");
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data1", "Once ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data1", "Once ", logger));
logger->Add("2");
writer->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data2", "upon ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data2", "upon ", logger));
logger->Add("3");
EXPECT_EQ(
@@ -1011,8 +1011,8 @@ TEST(SharedMemoryDataConsumerHandleWithoutBackpressureTest, AddData) {
TEST_F(ThreadedSharedMemoryDataConsumerHandleTest, Read) {
base::RunLoop run_loop;
- auto operation = base::WrapUnique(new ReadDataOperation(
- std::move(handle_), &loop_, run_loop.QuitClosure()));
+ auto operation = base::MakeUnique<ReadDataOperation>(
+ std::move(handle_), &loop_, run_loop.QuitClosure());
scoped_refptr<Logger> logger(new Logger);
base::Thread t("DataConsumerHandle test thread");
@@ -1024,15 +1024,15 @@ TEST_F(ThreadedSharedMemoryDataConsumerHandleTest, Read) {
logger->Add("1");
writer_->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data1", "Once ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data1", "Once ", logger));
writer_->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data2", "upon ", logger)));
- writer_->AddData(base::WrapUnique(
- new LoggingFixedReceivedData("data3", "a time ", logger)));
- writer_->AddData(base::WrapUnique(
- new LoggingFixedReceivedData("data4", "there ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data2", "upon ", logger));
writer_->AddData(
- base::WrapUnique(new LoggingFixedReceivedData("data5", "was ", logger)));
+ base::MakeUnique<LoggingFixedReceivedData>("data3", "a time ", logger));
+ writer_->AddData(
+ base::MakeUnique<LoggingFixedReceivedData>("data4", "there ", logger));
+ writer_->AddData(
+ base::MakeUnique<LoggingFixedReceivedData>("data5", "was ", logger));
writer_->Close();
logger->Add("2");
« no previous file with comments | « content/child/shared_memory_data_consumer_handle.cc ('k') | content/child/shared_memory_received_data_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698