Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2254153002: Cleanup of wtf/Assertions.*. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup of wtf/Assertions.*. - Use single-line comments. - Update comments - Unexport WTFGetBacktrace() and WTFPrintBacktrace() - Remove unused ASSERT_MSG_DISABLED macro This CL has no behavior changes. Committed: https://crrev.com/6a0772fce2b834d198f1edcea52755e802e19b22 Cr-Commit-Position: refs/heads/master@{#413408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -45 lines) Patch
M third_party/WebKit/Source/wtf/Assertions.h View 11 chunks +36 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
tkent
yutak@, ptal.
4 years, 4 months ago (2016-08-18 11:20:51 UTC) #6
Yuta Kitamura
lgtm
4 years, 4 months ago (2016-08-22 02:51:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254153002/1
4 years, 4 months ago (2016-08-22 03:00:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126808)
4 years, 4 months ago (2016-08-22 04:25:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254153002/1
4 years, 4 months ago (2016-08-22 04:41:26 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 05:20:48 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 05:22:07 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a0772fce2b834d198f1edcea52755e802e19b22
Cr-Commit-Position: refs/heads/master@{#413408}

Powered by Google App Engine
This is Rietveld 408576698