Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 225413019: input[type=color] should look like a button (Closed)

Created:
6 years, 8 months ago by tkent
Modified:
6 years, 8 months ago
Reviewers:
keishi
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

input[type=color] should look like a button - We should apply ButtonFace background instead of white. - For fallback style, use |1px #a9a9a solid| border to match Aura buttons. - Adjust paddings BUG=360997 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171032

Patch Set 1 #

Patch Set 2 : More NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -110 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/color/input-appearance-color.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/color/input-appearance-color-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/color/input-appearance-color-expected.txt View 2 chunks +108 lines, -108 lines 0 comments Download
M Source/core/css/html.css View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/themeWin.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tkent
Hattori-san, would you review this please?
6 years, 8 months ago (2014-04-08 05:35:53 UTC) #1
keishi
lgtm
6 years, 8 months ago (2014-04-08 05:39:40 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-08 05:44:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/225413019/1
6 years, 8 months ago (2014-04-08 05:44:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 06:09:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-08 06:09:00 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-08 06:14:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/225413019/20001
6 years, 8 months ago (2014-04-08 06:14:49 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 06:42:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-08 06:42:09 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-08 06:44:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/225413019/20001
6 years, 8 months ago (2014-04-08 06:44:37 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 07:27:17 UTC) #13
Message was sent while issue was closed.
Change committed as 171032

Powered by Google App Engine
This is Rietveld 408576698