chrome/common/extensions/api/networking_private.json - Issue 225413005: Added event to networkingPrivate extension that portal detection is completed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/networking_private.json

Issue 225413005: Added event to networkingPrivate extension that portal detection is completed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc ('k') | chrome/test/data/extensions/api_test/networking/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/networking_private.json

diff --git a/chrome/common/extensions/api/networking_private.json b/chrome/common/extensions/api/networking_private.json

index dee2866bb3fe6fe4972835cfbe71f0e0703d6734..5d3a0ac071c1b2d5f32adf0cfe2becc18003872c 100644

--- a/chrome/common/extensions/api/networking_private.json

+++ b/chrome/common/extensions/api/networking_private.json

@@ -413,9 +413,9 @@

"description": "Returns captive portal status for the network with networkGuid.",

"parameters": [

{

- "name": "networkGuid",

+ "name": "networkPath",

"type": "string",

- "description": "The unique identifier of the network to get captive portal status."

+ "description": "The path of the network to get captive portal status."

{

"name": "callback",

@@ -455,6 +455,21 @@

"items": { "type": "string" }

}

]

+ },

+ {

+ "name": "onPortalDetectionCompleted",

+ "type": "function",

+ "description": "Fired when a portal detection for a network completes. Sends a name of the network and corresponding captive portal status.",

+ "parameters": [

+ {

+ "name": "networkPath",

+ "type": "string"

+ },

+ {

+ "name": "status",

+ "$ref": "CaptivePortalStatus"

+ }

+ ]

}

]

}