Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 225413004: [gin] Add a v8::Platform implementation to allow for v8 posting tasks (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

[gin] Add a v8::Platform implementation to allow for v8 posting tasks This currently has no effect unless concurrent sweeping and job based sweeping is turned on in v8. BUG=v8:3015 R=abarth@chromium.org,dcarney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261872

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1 line) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M gin/gin.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
M gin/isolate_holder.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gin/per_isolate_data.h View 3 chunks +9 lines, -0 lines 0 comments Download
M gin/per_isolate_data.cc View 2 chunks +4 lines, -1 line 0 comments Download
A gin/public/v8_platform.h View 1 2 1 chunk +38 lines, -0 lines 1 comment Download
A gin/v8_platform.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-04 11:17:57 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-04 11:23:21 UTC) #2
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-04 16:45:43 UTC) #3
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-04 17:00:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/225413004/20001
6 years, 8 months ago (2014-04-04 17:00:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 17:44:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-04 17:44:28 UTC) #7
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-04 18:34:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/225413004/40001
6 years, 8 months ago (2014-04-04 18:35:31 UTC) #9
commit-bot: I haz the power
Change committed as 261872
6 years, 8 months ago (2014-04-04 21:09:22 UTC) #10
tfarina
6 years, 8 months ago (2014-04-05 03:42:12 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/225413004/diff/40001/gin/public/v8_platform.h
File gin/public/v8_platform.h (right):

https://codereview.chromium.org/225413004/diff/40001/gin/public/v8_platform.h...
gin/public/v8_platform.h:8: #include "base/basictypes.h"
super-tiny-nit: this should have been base/macros.h :)

Powered by Google App Engine
This is Rietveld 408576698