MD Settings: reduce complexity and overhead of prefs singleton

chrome/test/data/webui/settings/languages_tests.js

Index: chrome/test/data/webui/settings/languages_tests.js
diff --git a/chrome/test/data/webui/settings/languages_tests.js b/chrome/test/data/webui/settings/languages_tests.js
index 0eca9d49cfea361b343514b56197a67c56b17013..7b7b24caaa8eb0e7611cf951d3c3c1e490e2ac9e 100644
--- a/chrome/test/data/webui/settings/languages_tests.js
+++ b/chrome/test/data/webui/settings/languages_tests.js
@@ -73,7 +73,7 @@ cr.define('settings-languages', function() {
     setup(function() {
       var settingsPrefs = document.createElement('settings-prefs');
       var settingsPrivate = new settings.FakeSettingsPrivate(getFakePrefs());
-      settingsPrefs.initializeForTesting(settingsPrivate);
+      settingsPrefs.initialize(settingsPrivate);
 
       languageSettingsPrivate = new settings.FakeLanguageSettingsPrivate();
       languageSettingsPrivate.setSettingsPrefs(settingsPrefs);
@@ -118,34 +118,34 @@ cr.define('settings-languages', function() {
     });
 
     test('reorder languages', function() {
-      languageHelper.enableLanguage('sw');
+      languageHelper.enableLanguage('en-CA');
       assertEquals('en-US', languageHelper.languages.enabled[0].language.code);

[michaelpg, 2016/08/18 04:22:05]

the old code was assuming changes from previous test()s persisted, blegh. now
each test starts with a fresh instance of everything.

-      assertEquals('en-CA', languageHelper.languages.enabled[1].language.code);
-      assertEquals('sw', languageHelper.languages.enabled[2].language.code);
+      assertEquals('sw', languageHelper.languages.enabled[1].language.code);
+      assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
 
       // Can move a language up.
-      languageHelper.moveLanguage('sw', -1);
+      languageHelper.moveLanguage('en-CA', -1);
       assertEquals('en-US', languageHelper.languages.enabled[0].language.code);
-      assertEquals('sw', languageHelper.languages.enabled[1].language.code);
-      assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
+      assertEquals('en-CA', languageHelper.languages.enabled[1].language.code);
+      assertEquals('sw', languageHelper.languages.enabled[2].language.code);
 
       // Can move a language down.
       languageHelper.moveLanguage('en-US', 1);
-      assertEquals('sw', languageHelper.languages.enabled[0].language.code);
+      assertEquals('en-CA', languageHelper.languages.enabled[0].language.code);
       assertEquals('en-US', languageHelper.languages.enabled[1].language.code);
-      assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
+      assertEquals('sw', languageHelper.languages.enabled[2].language.code);
 
       // Moving the first language up has no effect.
-      languageHelper.moveLanguage('sw', -1);
-      assertEquals('sw', languageHelper.languages.enabled[0].language.code);
+      languageHelper.moveLanguage('en-CA', -1);
+      assertEquals('en-CA', languageHelper.languages.enabled[0].language.code);
       assertEquals('en-US', languageHelper.languages.enabled[1].language.code);
-      assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
+      assertEquals('sw', languageHelper.languages.enabled[2].language.code);
 
       // Moving the last language down has no effect.
-      languageHelper.moveLanguage('en-CA', 1);
-      assertEquals('sw', languageHelper.languages.enabled[0].language.code);
+      languageHelper.moveLanguage('sw', 1);
+      assertEquals('en-CA', languageHelper.languages.enabled[0].language.code);
       assertEquals('en-US', languageHelper.languages.enabled[1].language.code);
-      assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
+      assertEquals('sw', languageHelper.languages.enabled[2].language.code);
     });
 
     if (cr.isChromeOS) {