Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2746)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2254103003: Permission Action Reporting: Bundle report data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review Comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 3ea75c74115282983e75d3d5cce4576ac60d3d1a..d4ee865e21bd41eb956e5cd7927a2c4bb0374bd1 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -178,6 +178,27 @@ void RecordPermissionRequest(PermissionType permission,
} // anonymous namespace
+// PermissionReportInfo -------------------------------------------------------
+PermissionReportInfo::PermissionReportInfo(
+ const GURL& origin,
+ PermissionType permission,
+ PermissionAction action,
+ PermissionSourceUI source_ui,
+ PermissionRequestGestureType gesture_type,
+ PermissionPersistDecision persist_decision,
+ int num_prior_dismissals,
+ int num_prior_ignores)
+ : origin(origin), permission(permission), action(action),
+ source_ui(source_ui), gesture_type(gesture_type),
+ persist_decision(persist_decision),
+ num_prior_dismissals(num_prior_dismissals),
+ num_prior_ignores(num_prior_ignores) {}
+
+PermissionReportInfo::PermissionReportInfo(
+ const PermissionReportInfo& other) = default;
+
+// PermissionUmaUtil ----------------------------------------------------------
+
const char PermissionUmaUtil::kPermissionsPromptShown[] =
"Permissions.Prompt.Shown";
const char PermissionUmaUtil::kPermissionsPromptShownGesture[] =
@@ -586,14 +607,16 @@ void PermissionUmaUtil::RecordPermissionAction(
const GURL& requesting_origin,
Profile* profile) {
if (IsOptedIntoPermissionActionReporting(profile)) {
+ // TODO(kcarattini): Pass in the actual persist decision when it becomes
+ // available.
+ PermissionReportInfo report_info(requesting_origin, permission, action,
+ source_ui, gesture_type, PermissionPersistDecision::UNSPECIFIED,
+ PermissionDecisionAutoBlocker::GetDismissCount(
+ requesting_origin, permission, profile),
+ PermissionDecisionAutoBlocker::GetIgnoreCount(
+ requesting_origin, permission, profile));
g_browser_process->safe_browsing_service()
- ->ui_manager()
- ->ReportPermissionAction(requesting_origin, permission, action,
- source_ui, gesture_type,
- PermissionDecisionAutoBlocker::GetDismissCount(
- requesting_origin, permission, profile),
- PermissionDecisionAutoBlocker::GetIgnoreCount(
- requesting_origin, permission, profile));
+ ->ui_manager()->ReportPermissionAction(report_info);
}
bool secure_origin = content::IsOriginSecure(requesting_origin);

Powered by Google App Engine
This is Rietveld 408576698