Permission Action Reporting: Bundle report data.

chrome/browser/permissions/permission_uma_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "chrome/browser/permissions/permission_util.h"
 
 enum class PermissionRequestGestureType;
 class GURL;
+class PermissionRequest;
 class Profile;
 
 namespace content {
 enum class PermissionType;
 }  // namespace content
 
-class PermissionRequest;
-
 // This should stay in sync with the SourceUI enum in the permission report
 // protobuf (src/chrome/common/safe_browsing/permission_report.proto).
 enum class PermissionSourceUI {
   PROMPT = 0,
   OIB = 1,
   SITE_SETTINGS = 2,
   PAGE_ACTION = 3,
 
   // Always keep this at the end.
   SOURCE_UI_NUM,
 };
 
+// This should stay in sync with the PersistDecision enum in the permission
+// report message (src/chrome/common/safe_browsing/permission_report.proto).
+enum class PermissionPersistDecision {
+  UNSPECIFIED = 0,
+  PERSISTED = 1,
+  NOT_PERSISTED = 2,
+};
+
+// A bundle for the information sent in a PermissionReport.
+struct PermissionReportInfo {
+  PermissionReportInfo(

[Nathan Parker, 2016/08/19 00:14:34]

Having this constructor sort of defeats some of the vale, since it allows the
caller to pass things unnamed, and you could still mix up the last two ints.

If you think it's useful (it does reduce verbiage), I could be convinced.

[kcarattini, 2016/08/19 01:00:39]

True, but at least it only happens in one place now. It also guarantees that all
of the fields are set. Setting each field individually seems somewhat excessive
to me.

+      const GURL& origin,
+      content::PermissionType permission,
+      PermissionAction action,
+      PermissionSourceUI source_ui,
+      PermissionRequestGestureType gesture_type,
+      PermissionPersistDecision persist_decision,
+      int num_prior_dismissals,
+      int num_prior_ignores);
+
+  PermissionReportInfo(const PermissionReportInfo& other);
+
+  GURL origin;
+  content::PermissionType permission;
+  PermissionAction action;
+  PermissionSourceUI source_ui;
+  PermissionRequestGestureType gesture_type;
+  PermissionPersistDecision persist_decision;
+  int num_prior_dismissals;
+  int num_prior_ignores;
+};
+
 // Provides a convenient way of logging UMA for permission related operations.
 class PermissionUmaUtil {
  public:
   static const char kPermissionsPromptShown[];
   static const char kPermissionsPromptShownGesture[];
   static const char kPermissionsPromptShownNoGesture[];
   static const char kPermissionsPromptAccepted[];
   static const char kPermissionsPromptAcceptedGesture[];
   static const char kPermissionsPromptAcceptedNoGesture[];
   static const char kPermissionsPromptDenied[];
@@ skipping 83 matching lines @@
                                      PermissionAction action,
                                      PermissionSourceUI source_ui,
                                      PermissionRequestGestureType gesture_type,
                                      const GURL& requesting_origin,
                                      Profile* profile);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_