Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: media/formats/webm/webm_cluster_parser.cc

Issue 2254093002: Return buffers from StreamParsers in a single unified map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restored calling GetBuffers after each Parse in WebM test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/webm/webm_cluster_parser.h ('k') | media/formats/webm/webm_cluster_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/webm/webm_cluster_parser.cc
diff --git a/media/formats/webm/webm_cluster_parser.cc b/media/formats/webm/webm_cluster_parser.cc
index c9b85b242415566ccfc0ed68356be39f195b0b4e..b2718d562abea1a261e67ffad122c253de992519 100644
--- a/media/formats/webm/webm_cluster_parser.cc
+++ b/media/formats/webm/webm_cluster_parser.cc
@@ -118,20 +118,6 @@ int WebMClusterParser::Parse(const uint8_t* buf, int size) {
return result;
}
-const WebMClusterParser::BufferQueue& WebMClusterParser::GetAudioBuffers() {
- if (ready_buffer_upper_bound_ == kNoDecodeTimestamp())
- UpdateReadyBuffers();
-
- return audio_.ready_buffers();
-}
-
-const WebMClusterParser::BufferQueue& WebMClusterParser::GetVideoBuffers() {
- if (ready_buffer_upper_bound_ == kNoDecodeTimestamp())
- UpdateReadyBuffers();
-
- return video_.ready_buffers();
-}
-
const WebMClusterParser::TextBufferQueueMap&
WebMClusterParser::GetTextBuffers() {
if (ready_buffer_upper_bound_ == kNoDecodeTimestamp())
@@ -151,6 +137,25 @@ WebMClusterParser::GetTextBuffers() {
return text_buffers_map_;
}
+void WebMClusterParser::GetBuffers(StreamParser::BufferQueueMap* buffers) {
+ DCHECK(buffers->empty());
+ if (ready_buffer_upper_bound_ == kNoDecodeTimestamp())
+ UpdateReadyBuffers();
+ const BufferQueue& audio_buffers = audio_.ready_buffers();
+ if (!audio_buffers.empty()) {
+ buffers->insert(std::make_pair(audio_.track_num(), audio_buffers));
+ }
+ const BufferQueue& video_buffers = video_.ready_buffers();
+ if (!video_buffers.empty()) {
+ buffers->insert(std::make_pair(video_.track_num(), video_buffers));
+ }
+ const WebMClusterParser::TextBufferQueueMap& text_buffers = GetTextBuffers();
+ for (const auto& it : text_buffers) {
+ DCHECK(!it.second.empty());
+ buffers->insert(it);
+ }
+}
+
base::TimeDelta WebMClusterParser::TryGetEncodedAudioDuration(
const uint8_t* data,
int size) {
« no previous file with comments | « media/formats/webm/webm_cluster_parser.h ('k') | media/formats/webm/webm_cluster_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698