Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: media/formats/mp2t/mp2t_stream_parser.cc

Issue 2254093002: Return buffers from StreamParsers in a single unified map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restored calling GetBuffers after each Parse in WebM test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/common/stream_parser_test_base.cc ('k') | media/formats/mp2t/mp2t_stream_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp2t/mp2t_stream_parser.cc
diff --git a/media/formats/mp2t/mp2t_stream_parser.cc b/media/formats/mp2t/mp2t_stream_parser.cc
index c66afeb8668d90adc53456d32343d37acbbf2875..2d9da61c01b1859143b4fd7db18acf51ed2dfbd7 100644
--- a/media/formats/mp2t/mp2t_stream_parser.cc
+++ b/media/formats/mp2t/mp2t_stream_parser.cc
@@ -512,10 +512,12 @@ std::unique_ptr<MediaTracks> GenerateMediaTrackInfo(
// TODO(servolk): Implement proper sourcing of media track info as described
// in crbug.com/590085
if (audio_config.IsValidConfig()) {
- media_tracks->AddAudioTrack(audio_config, 1, "main", "", "");
+ media_tracks->AddAudioTrack(audio_config, kMp2tAudioTrackId, "main", "",
+ "");
}
if (video_config.IsValidConfig()) {
- media_tracks->AddVideoTrack(video_config, 2, "main", "", "");
+ media_tracks->AddVideoTrack(video_config, kMp2tVideoTrackId, "main", "",
+ "");
}
return media_tracks;
}
@@ -655,15 +657,16 @@ bool Mp2tStreamParser::EmitRemainingBuffers() {
}
// Add buffers.
- TextBufferQueueMap empty_text_map;
- if (!queue_with_config.audio_queue.empty() ||
- !queue_with_config.video_queue.empty()) {
- if (!new_buffers_cb_.Run(queue_with_config.audio_queue,
- queue_with_config.video_queue,
- empty_text_map)) {
- return false;
- }
- }
+ BufferQueueMap buffer_queue_map;
+ if (!queue_with_config.audio_queue.empty())
+ buffer_queue_map.insert(
+ std::make_pair(kMp2tAudioTrackId, queue_with_config.audio_queue));
+ if (!queue_with_config.video_queue.empty())
+ buffer_queue_map.insert(
+ std::make_pair(kMp2tVideoTrackId, queue_with_config.video_queue));
+
+ if (!buffer_queue_map.empty() && !new_buffers_cb_.Run(buffer_queue_map))
+ return false;
buffer_queue_chain_.pop_front();
}
« no previous file with comments | « media/formats/common/stream_parser_test_base.cc ('k') | media/formats/mp2t/mp2t_stream_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698