Return buffers from StreamParsers in a single unified map

media/base/stream_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/stream_parser.h"
 
 #include "media/base/stream_parser_buffer.h"
 
 namespace media {
 
@@ skipping 93 matching lines @@
     // the last buffer in |merged_buffers|, advance the corresponding
     // input BufferQueue iterator, and continue.
     scoped_refptr<StreamParserBuffer> buffer =
         *itrs[index_of_queue_with_next_decode_timestamp];
     last_decode_timestamp = buffer->GetDecodeTimestamp();
     merged_buffers->push_back(buffer);
     ++itrs[index_of_queue_with_next_decode_timestamp];
   }
 }
 
-bool MergeBufferQueues(const StreamParser::BufferQueue& audio_buffers,
-                       const StreamParser::BufferQueue& video_buffers,
-                       const StreamParser::TextBufferQueueMap& text_buffers,
+bool MergeBufferQueues(const StreamParser::BufferQueueMap& buffer_queue_map,
                        StreamParser::BufferQueue* merged_buffers) {
   DCHECK(merged_buffers);
 
   // Prepare vector containing pointers to any provided non-empty buffer queues.
+
+  // Append audio buffer queues first, before all other types, since
+  // FrameProcessorTest.AudioVideo_Discontinuity currently depends on audio
+  // buffers being processed first.
   std::vector<const StreamParser::BufferQueue*> buffer_queues;

[DaleCurtis, 2016/08/19 01:06:25]

Isn't there an insert() method that can do this without the iteration?

[servolk, 2016/08/19 01:37:31]

Do you mean something like std::copy_if or something else?

-  if (!audio_buffers.empty())
-    buffer_queues.push_back(&audio_buffers);
-  if (!video_buffers.empty())
-    buffer_queues.push_back(&video_buffers);
-  for (StreamParser::TextBufferQueueMap::const_iterator map_itr =
-           text_buffers.begin();
-       map_itr != text_buffers.end();
-       map_itr++) {
-    if (!map_itr->second.empty())
-      buffer_queues.push_back(&(map_itr->second));
+  for (const auto& it : buffer_queue_map) {
+    DCHECK(!it.second.empty());
+    if (it.second[0]->type() == DemuxerStream::AUDIO)
+      buffer_queues.push_back(&it.second);
+  }
+  for (const auto& it : buffer_queue_map) {
+    DCHECK(!it.second.empty());
+    if (it.second[0]->type() != DemuxerStream::AUDIO)
+      buffer_queues.push_back(&it.second);
   }
 
   // Do the merge.
   return MergeBufferQueuesInternal(buffer_queues, merged_buffers);
 }
 
 }  // namespace media