Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: media/formats/webm/webm_stream_parser_unittest.cc

Issue 2254093002: Return buffers from StreamParsers in a single unified map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restored calling GetBuffers after each Parse in WebM test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/formats/webm/webm_stream_parser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/formats/webm/webm_stream_parser.h" 5 #include "media/formats/webm/webm_stream_parser.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "media/base/decoder_buffer.h" 10 #include "media/base/decoder_buffer.h"
(...skipping 20 matching lines...) Expand all
31 const StreamParser::InitParameters& expected_params) { 31 const StreamParser::InitParameters& expected_params) {
32 scoped_refptr<DecoderBuffer> buffer = ReadTestDataFile(filename); 32 scoped_refptr<DecoderBuffer> buffer = ReadTestDataFile(filename);
33 parser_.reset(new WebMStreamParser()); 33 parser_.reset(new WebMStreamParser());
34 Demuxer::EncryptedMediaInitDataCB encrypted_media_init_data_cb = 34 Demuxer::EncryptedMediaInitDataCB encrypted_media_init_data_cb =
35 base::Bind(&WebMStreamParserTest::OnEncryptedMediaInitData, 35 base::Bind(&WebMStreamParserTest::OnEncryptedMediaInitData,
36 base::Unretained(this)); 36 base::Unretained(this));
37 37
38 EXPECT_CALL(*this, InitCB(_)); 38 EXPECT_CALL(*this, InitCB(_));
39 EXPECT_CALL(*this, NewMediaSegmentCB()).Times(testing::AnyNumber()); 39 EXPECT_CALL(*this, NewMediaSegmentCB()).Times(testing::AnyNumber());
40 EXPECT_CALL(*this, EndMediaSegmentCB()).Times(testing::AnyNumber()); 40 EXPECT_CALL(*this, EndMediaSegmentCB()).Times(testing::AnyNumber());
41 EXPECT_CALL(*this, NewBuffersCB(_, _, _)) 41 EXPECT_CALL(*this, NewBuffersCB(_))
42 .Times(testing::AnyNumber()) 42 .Times(testing::AnyNumber())
43 .WillRepeatedly(testing::Return(true)); 43 .WillRepeatedly(testing::Return(true));
44 parser_->Init( 44 parser_->Init(
45 base::Bind(&WebMStreamParserTest::InitF, base::Unretained(this), 45 base::Bind(&WebMStreamParserTest::InitF, base::Unretained(this),
46 expected_params), 46 expected_params),
47 base::Bind(&WebMStreamParserTest::NewConfigCB, base::Unretained(this)), 47 base::Bind(&WebMStreamParserTest::NewConfigCB, base::Unretained(this)),
48 base::Bind(&WebMStreamParserTest::NewBuffersCB, base::Unretained(this)), 48 base::Bind(&WebMStreamParserTest::NewBuffersCB, base::Unretained(this)),
49 false, // don't ignore_text_track 49 false, // don't ignore_text_track
50 encrypted_media_init_data_cb, 50 encrypted_media_init_data_cb,
51 base::Bind(&WebMStreamParserTest::NewMediaSegmentCB, 51 base::Bind(&WebMStreamParserTest::NewMediaSegmentCB,
(...skipping 20 matching lines...) Expand all
72 72
73 MOCK_METHOD1(InitCB, void(const StreamParser::InitParameters& params)); 73 MOCK_METHOD1(InitCB, void(const StreamParser::InitParameters& params));
74 74
75 bool NewConfigCB(std::unique_ptr<MediaTracks> tracks, 75 bool NewConfigCB(std::unique_ptr<MediaTracks> tracks,
76 const StreamParser::TextTrackConfigMap& text_track_map) { 76 const StreamParser::TextTrackConfigMap& text_track_map) {
77 DCHECK(tracks.get()); 77 DCHECK(tracks.get());
78 media_tracks_ = std::move(tracks); 78 media_tracks_ = std::move(tracks);
79 return true; 79 return true;
80 } 80 }
81 81
82 MOCK_METHOD3(NewBuffersCB, 82 MOCK_METHOD1(NewBuffersCB, bool(const StreamParser::BufferQueueMap&));
83 bool(const StreamParser::BufferQueue&,
84 const StreamParser::BufferQueue&,
85 const StreamParser::TextBufferQueueMap&));
86 MOCK_METHOD2(OnEncryptedMediaInitData, 83 MOCK_METHOD2(OnEncryptedMediaInitData,
87 void(EmeInitDataType init_data_type, 84 void(EmeInitDataType init_data_type,
88 const std::vector<uint8_t>& init_data)); 85 const std::vector<uint8_t>& init_data));
89 MOCK_METHOD0(NewMediaSegmentCB, void()); 86 MOCK_METHOD0(NewMediaSegmentCB, void());
90 MOCK_METHOD0(EndMediaSegmentCB, void()); 87 MOCK_METHOD0(EndMediaSegmentCB, void());
91 88
92 scoped_refptr<testing::StrictMock<MockMediaLog>> media_log_; 89 scoped_refptr<testing::StrictMock<MockMediaLog>> media_log_;
93 std::unique_ptr<WebMStreamParser> parser_; 90 std::unique_ptr<WebMStreamParser> parser_;
94 std::unique_ptr<MediaTracks> media_tracks_; 91 std::unique_ptr<MediaTracks> media_tracks_;
95 }; 92 };
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 params.detected_audio_track_count = 1; 147 params.detected_audio_track_count = 1;
151 params.detected_video_track_count = 1; 148 params.detected_video_track_count = 1;
152 params.detected_text_track_count = 1; 149 params.detected_text_track_count = 1;
153 ParseWebMFile("bear-vp8-webvtt.webm", params); 150 ParseWebMFile("bear-vp8-webvtt.webm", params);
154 EXPECT_EQ(media_tracks_->tracks().size(), 2u); 151 EXPECT_EQ(media_tracks_->tracks().size(), 2u);
155 EXPECT_EQ(media_tracks_->tracks()[0]->type(), MediaTrack::Video); 152 EXPECT_EQ(media_tracks_->tracks()[0]->type(), MediaTrack::Video);
156 EXPECT_EQ(media_tracks_->tracks()[1]->type(), MediaTrack::Audio); 153 EXPECT_EQ(media_tracks_->tracks()[1]->type(), MediaTrack::Audio);
157 } 154 }
158 155
159 } // namespace media 156 } // namespace media
OLDNEW
« no previous file with comments | « media/formats/webm/webm_stream_parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698