Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: media/formats/webm/webm_stream_parser.cc

Issue 2254093002: Return buffers from StreamParsers in a single unified map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restored calling GetBuffers after each Parse in WebM test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/formats/webm/webm_stream_parser.h" 5 #include "media/formats/webm/webm_stream_parser.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 } 257 }
258 258
259 int WebMStreamParser::ParseCluster(const uint8_t* data, int size) { 259 int WebMStreamParser::ParseCluster(const uint8_t* data, int size) {
260 if (!cluster_parser_) 260 if (!cluster_parser_)
261 return -1; 261 return -1;
262 262
263 int bytes_parsed = cluster_parser_->Parse(data, size); 263 int bytes_parsed = cluster_parser_->Parse(data, size);
264 if (bytes_parsed < 0) 264 if (bytes_parsed < 0)
265 return bytes_parsed; 265 return bytes_parsed;
266 266
267 const BufferQueue& audio_buffers = cluster_parser_->GetAudioBuffers(); 267 BufferQueueMap buffer_queue_map;
268 const BufferQueue& video_buffers = cluster_parser_->GetVideoBuffers(); 268 cluster_parser_->GetBuffers(&buffer_queue_map);
269 const TextBufferQueueMap& text_map = cluster_parser_->GetTextBuffers();
270 269
271 bool cluster_ended = cluster_parser_->cluster_ended(); 270 bool cluster_ended = cluster_parser_->cluster_ended();
272 271
273 if ((!audio_buffers.empty() || !video_buffers.empty() || 272 if (!buffer_queue_map.empty() && !new_buffers_cb_.Run(buffer_queue_map)) {
274 !text_map.empty()) &&
275 !new_buffers_cb_.Run(audio_buffers, video_buffers, text_map)) {
276 return -1; 273 return -1;
277 } 274 }
278 275
279 if (cluster_ended) { 276 if (cluster_ended) {
280 ChangeState(kParsingHeaders); 277 ChangeState(kParsingHeaders);
281 end_of_segment_cb_.Run(); 278 end_of_segment_cb_.Run();
282 } 279 }
283 280
284 return bytes_parsed; 281 return bytes_parsed;
285 } 282 }
286 283
287 void WebMStreamParser::OnEncryptedMediaInitData(const std::string& key_id) { 284 void WebMStreamParser::OnEncryptedMediaInitData(const std::string& key_id) {
288 std::vector<uint8_t> key_id_vector(key_id.begin(), key_id.end()); 285 std::vector<uint8_t> key_id_vector(key_id.begin(), key_id.end());
289 encrypted_media_init_data_cb_.Run(EmeInitDataType::WEBM, key_id_vector); 286 encrypted_media_init_data_cb_.Run(EmeInitDataType::WEBM, key_id_vector);
290 } 287 }
291 288
292 } // namespace media 289 } // namespace media
OLDNEW
« no previous file with comments | « media/formats/webm/webm_cluster_parser_unittest.cc ('k') | media/formats/webm/webm_stream_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698