Return buffers from StreamParsers in a single unified map

media/formats/mp2t/mp2t_stream_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/mp2t/mp2t_stream_parser.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 127 matching lines @@
         LOG(ERROR) << "Unexpected track type " << track->type();
         EXPECT_TRUE(false);
       }
     }
     EXPECT_TRUE(found_audio_track);
     EXPECT_EQ(has_video_, found_video_track);
     config_count_++;
     return true;
   }
 
-
-  void DumpBuffers(const std::string& label,
-                   const StreamParser::BufferQueue& buffers) {
-    DVLOG(2) << "DumpBuffers: " << label << " size " << buffers.size();
-    for (StreamParser::BufferQueue::const_iterator buf = buffers.begin();
-         buf != buffers.end(); buf++) {
-      DVLOG(3) << "  n=" << buf - buffers.begin()
-               << ", size=" << (*buf)->data_size()
-               << ", dur=" << (*buf)->duration().InMilliseconds();
-    }
-  }
-
-  bool OnNewBuffers(const StreamParser::BufferQueue& audio_buffers,
-                    const StreamParser::BufferQueue& video_buffers,
-                    const StreamParser::TextBufferQueueMap& text_map) {
+  bool OnNewBuffers(const StreamParser::BufferQueueMap& buffer_queue_map) {
     EXPECT_GT(config_count_, 0);
-    DumpBuffers("audio_buffers", audio_buffers);
-    DumpBuffers("video_buffers", video_buffers);
-
     // Ensure that track ids are properly assigned on all emitted buffers.
-    for (const auto& buf : audio_buffers) {
-      EXPECT_EQ(audio_track_id_, buf->track_id());
-    }
-    for (const auto& buf : video_buffers) {
-      EXPECT_EQ(video_track_id_, buf->track_id());
+    for (const auto& it : buffer_queue_map) {
+      DVLOG(3) << "Buffers for track_id=" << it.first;
+      for (const auto& buf : it.second) {
+        DVLOG(3) << "  track_id=" << buf->track_id()
+                 << ", size=" << buf->data_size()
+                 << ", pts=" << buf->timestamp().InSecondsF()
+                 << ", dts=" << buf->GetDecodeTimestamp().InSecondsF()
+                 << ", dur=" << buf->duration().InSecondsF();
+        EXPECT_EQ(it.first, buf->track_id());
+      }
     }
 
-    // TODO(wolenetz/acolwell): Add text track support to more MSE parsers. See
-    // http://crbug.com/336926.
-    if (!text_map.empty())
-      return false;
+    const StreamParser::BufferQueue empty_buffers;
+    const auto& itr_audio = buffer_queue_map.find(audio_track_id_);
+    const StreamParser::BufferQueue& audio_buffers =
+        (itr_audio == buffer_queue_map.end()) ? empty_buffers
+                                              : itr_audio->second;
+
+    const auto& itr_video = buffer_queue_map.find(video_track_id_);
+    const StreamParser::BufferQueue& video_buffers =
+        (itr_video == buffer_queue_map.end()) ? empty_buffers
+                                              : itr_video->second;
 
     // Verify monotonicity.
     if (!IsMonotonic(video_buffers))
       return false;
     if (!IsMonotonic(audio_buffers))
       return false;
 
     if (!video_buffers.empty()) {
       DecodeTimestamp first_dts = video_buffers.front()->GetDecodeTimestamp();
       DecodeTimestamp last_dts = video_buffers.back()->GetDecodeTimestamp();
@@ skipping 134 matching lines @@
   parser_->Flush();
   EXPECT_EQ(audio_frame_count_, 40);
   EXPECT_EQ(video_frame_count_, 0);
   // This stream has no mid-stream configuration change.
   EXPECT_EQ(config_count_, 1);
   EXPECT_EQ(segment_count_, 1);
 }
 
 }  // namespace mp2t
 }  // namespace media