Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: media/formats/common/stream_parser_test_base.cc

Issue 2254093002: Return buffers from StreamParsers in a single unified map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restored calling GetBuffers after each Parse in WebM test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/formats/common/stream_parser_test_base.h" 5 #include "media/formats/common/stream_parser_test_base.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 EXPECT_EQ(tracks->tracks().size(), 1u); 93 EXPECT_EQ(tracks->tracks().size(), 1u);
94 const auto& track = tracks->tracks()[0]; 94 const auto& track = tracks->tracks()[0];
95 EXPECT_EQ(track->type(), MediaTrack::Audio); 95 EXPECT_EQ(track->type(), MediaTrack::Audio);
96 audio_track_id_ = track->bytestream_track_id(); 96 audio_track_id_ = track->bytestream_track_id();
97 last_audio_config_ = tracks->getAudioConfig(track->bytestream_track_id()); 97 last_audio_config_ = tracks->getAudioConfig(track->bytestream_track_id());
98 EXPECT_TRUE(last_audio_config_.IsValidConfig()); 98 EXPECT_TRUE(last_audio_config_.IsValidConfig());
99 return true; 99 return true;
100 } 100 }
101 101
102 bool StreamParserTestBase::OnNewBuffers( 102 bool StreamParserTestBase::OnNewBuffers(
103 const StreamParser::BufferQueue& audio_buffers, 103 const StreamParser::BufferQueueMap& buffer_queue_map) {
104 const StreamParser::BufferQueue& video_buffers, 104 EXPECT_EQ(1u, buffer_queue_map.size());
105 const StreamParser::TextBufferQueueMap& text_map) { 105 const auto& itr_audio = buffer_queue_map.find(audio_track_id_);
106 EXPECT_NE(buffer_queue_map.end(), itr_audio);
107 const StreamParser::BufferQueue& audio_buffers = itr_audio->second;
106 EXPECT_FALSE(audio_buffers.empty()); 108 EXPECT_FALSE(audio_buffers.empty());
107 EXPECT_TRUE(video_buffers.empty());
108 109
109 // Ensure that track ids are properly assigned on all emitted buffers. 110 // Ensure that track ids are properly assigned on all emitted buffers.
110 for (const auto& buf : audio_buffers) { 111 for (const auto& buf : audio_buffers) {
111 EXPECT_EQ(audio_track_id_, buf->track_id()); 112 EXPECT_EQ(audio_track_id_, buf->track_id());
112 } 113 }
113 114
114 // TODO(wolenetz/acolwell): Add text track support to more MSE parsers. See
115 // http://crbug.com/336926.
116 EXPECT_TRUE(text_map.empty());
117
118 const std::string buffers_str = BufferQueueToString(audio_buffers); 115 const std::string buffers_str = BufferQueueToString(audio_buffers);
119 DVLOG(1) << __FUNCTION__ << " : " << buffers_str; 116 DVLOG(1) << __FUNCTION__ << " : " << buffers_str;
120 results_stream_ << buffers_str; 117 results_stream_ << buffers_str;
121 return true; 118 return true;
122 } 119 }
123 120
124 void StreamParserTestBase::OnKeyNeeded(EmeInitDataType type, 121 void StreamParserTestBase::OnKeyNeeded(EmeInitDataType type,
125 const std::vector<uint8_t>& init_data) { 122 const std::vector<uint8_t>& init_data) {
126 DVLOG(1) << __FUNCTION__ << "(" << static_cast<int>(type) << ", " 123 DVLOG(1) << __FUNCTION__ << "(" << static_cast<int>(type) << ", "
127 << init_data.size() << ")"; 124 << init_data.size() << ")";
128 } 125 }
129 126
130 void StreamParserTestBase::OnNewSegment() { 127 void StreamParserTestBase::OnNewSegment() {
131 DVLOG(1) << __FUNCTION__; 128 DVLOG(1) << __FUNCTION__;
132 results_stream_ << "NewSegment"; 129 results_stream_ << "NewSegment";
133 } 130 }
134 131
135 void StreamParserTestBase::OnEndOfSegment() { 132 void StreamParserTestBase::OnEndOfSegment() {
136 DVLOG(1) << __FUNCTION__; 133 DVLOG(1) << __FUNCTION__;
137 results_stream_ << "EndOfSegment"; 134 results_stream_ << "EndOfSegment";
138 } 135 }
139 136
140 } // namespace media 137 } // namespace media
OLDNEW
« no previous file with comments | « media/formats/common/stream_parser_test_base.h ('k') | media/formats/mp2t/mp2t_stream_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698