components/sync/device_info/device_info_service.h - Issue 2254083002: [Sync] Convert NonBlockingDataTypeController to be single-thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/device_info/device_info_service.h

Issue 2254083002: [Sync] Convert NonBlockingDataTypeController to be single-thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dt

Patch Set: Update DeviceInfoService. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/sync/device_info/device_info_service.h

diff --git a/components/sync/device_info/device_info_service.h b/components/sync/device_info/device_info_service.h

index 3a1db39732dd2c02179dd054b364f03217735461..40096e900ab945fe388e01efe4226389f7b385e1 100644

--- a/components/sync/device_info/device_info_service.h

+++ b/components/sync/device_info/device_info_service.h

@@ -180,9 +180,6 @@ class DeviceInfoService : public syncer_v2::ModelTypeService,

// Used to update our local device info once every pulse interval.

base::OneShotTimer pulse_timer_;

- // Should always be last member.

- base::WeakPtrFactory<DeviceInfoService> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(DeviceInfoService);

};

« no previous file with comments | « components/sync/api/model_type_service.h ('k') | components/sync/device_info/device_info_service.cc » ('j') | no next file with comments »