Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2254073002: Remove WTF::static_pointer_cast functions. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, Mikhail, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTF::static_pointer_cast functions. They are RefPtr/PassRefPtr versions of std::static_pointer_cast, and not used any longer in Blink. This CL also removes unused SVGListPropertyHelper::toDerived(), which used WTF::static_pointer_cast in pre-Oilpan era. This CL has no behavior changes. BUG=583200 Committed: https://crrev.com/945412be9ef3e46e0203c872903af78d0f3fe03f Cr-Commit-Position: refs/heads/master@{#412734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yutak@, would you review this please?
4 years, 4 months ago (2016-08-18 03:13:18 UTC) #6
Yuta Kitamura
lgtm
4 years, 4 months ago (2016-08-18 03:36:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254073002/1
4 years, 4 months ago (2016-08-18 03:49:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 04:01:19 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 04:03:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/945412be9ef3e46e0203c872903af78d0f3fe03f
Cr-Commit-Position: refs/heads/master@{#412734}

Powered by Google App Engine
This is Rietveld 408576698