Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2254033002: Encourage IOSurface reuse for CSS filter effects. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
ccameron, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Encourage IOSurface reuse for CSS filter effects. This comes at the expense of a temporary increase in memory usage. The resource expiration delay was changed from 1s to 3s, so there's no long term increase in memory usage, unless there is a corresponding performance gain. BUG=636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b8818116176eebbb37637a3b30cec284aa01d937 Cr-Commit-Position: refs/heads/master@{#413489}

Patch Set 1 #

Patch Set 2 : Comments from ericrk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
M cc/output/gl_renderer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/resource_pool.h View 1 3 chunks +14 lines, -11 lines 0 comments Download
M cc/resources/resource_pool.cc View 1 3 chunks +5 lines, -9 lines 0 comments Download
M cc/resources/resource_pool_unittest.cc View 1 3 chunks +14 lines, -11 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
erikchen
ccameron: Please review.
4 years, 4 months ago (2016-08-17 20:02:18 UTC) #4
erikchen
ericrk: Please review. ccameron is kind-of mostly OOO.
4 years, 4 months ago (2016-08-19 17:41:53 UTC) #9
ericrk
lgtm I wonder if we should just pass the delay in the constructor and keep ...
4 years, 4 months ago (2016-08-19 18:36:56 UTC) #10
erikchen
On 2016/08/19 18:36:56, ericrk wrote: > lgtm > > I wonder if we should just ...
4 years, 4 months ago (2016-08-22 17:34:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254033002/20001
4 years, 4 months ago (2016-08-22 17:35:26 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 18:51:44 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:53:25 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8818116176eebbb37637a3b30cec284aa01d937
Cr-Commit-Position: refs/heads/master@{#413489}

Powered by Google App Engine
This is Rietveld 408576698