Extract Profile-independent GCMService from GCMProfileService

chrome/browser/sync/profile_sync_service.cc

Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index fce995895f4b3daa64f95cc3cff52b8c5b00ad66..c4eafb4bc8fa510f6e89704e6861e9adb2a8f375 100644
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -31,6 +31,7 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/services/gcm/gcm_profile_service.h"
 #include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
+#include "chrome/browser/services/gcm/gcm_service.h"
 #include "chrome/browser/signin/about_signin_internals_factory.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
@@ -1012,13 +1013,13 @@ void ProfileSyncService::OnExperimentsChanged(
     profile()->GetPrefs()->SetBoolean(prefs::kGCMChannelEnabled,
                                       experiments.gcm_channel_state ==
                                           syncer::Experiments::ENABLED);
-    gcm::GCMProfileService* gcm_profile_service =
+    gcm::GCMService* gcm_service =

[jianli, 2014/04/10 20:39:56]

GCMProfileServiceFactory::GetForProfile returns GCMProfileService. Why bothering
to casting to GCMService?

[bartfab (slow), 2014/04/11 16:58:52]

I wanted to make it explicit that in this case here, no Profile-specific
functionality of GCMService is needed. But you are right, in a class that has
"Profile" in its name, using the Profile-specific version of GCMService is no
crime. Fixed.

         gcm::GCMProfileServiceFactory::GetForProfile(profile());
-    if (gcm_profile_service) {
+    if (gcm_service) {
       if (experiments.gcm_channel_state == syncer::Experiments::SUPPRESSED)
-        gcm_profile_service->Stop();
+        gcm_service->Stop();
       else
-        gcm_profile_service->Start();
+        gcm_service->Start();
     }
   } else {
     profile()->GetPrefs()->ClearPref(prefs::kGCMChannelEnabled);