chrome/browser/services/gcm/gcm_profile_service_factory.h - Issue 225403021: Extract Profile-independent GCMService from GCMProfileService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_profile_service_factory.h

Issue 225403021: Extract Profile-independent GCMService from GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Restore real IO thread in unit tests. Remove sources of flakiness by waiting instead of pumping whe… Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/services/gcm/gcm_profile_service_factory.h

diff --git a/chrome/browser/services/gcm/gcm_profile_service_factory.h b/chrome/browser/services/gcm/gcm_profile_service_factory.h

index be27b7d8af9bb7452b3ed4018367c2559e259de3..2e5763ea4f3f1e3d21a56a1edea80393ad3d468e 100644

--- a/chrome/browser/services/gcm/gcm_profile_service_factory.h

+++ b/chrome/browser/services/gcm/gcm_profile_service_factory.h

@@ -16,8 +16,7 @@ namespace gcm {

class GCMProfileService;

// Singleton that owns all GCMProfileService and associates them with

-// Profiles. Listens for the Profile's destruction notification and cleans up

-// the associated GCMProfileService.

+// Profiles.

class GCMProfileServiceFactory : public BrowserContextKeyedServiceFactory {

public:

static GCMProfileService* GetForProfile(Profile* profile);