chrome/browser/services/gcm/gcm_client_mock.cc - Issue 225403021: Extract Profile-independent GCMService from GCMProfileService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_client_mock.cc

Issue 225403021: Extract Profile-independent GCMService from GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Restore real IO thread in unit tests. Remove sources of flakiness by waiting instead of pumping whe… Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/services/gcm/gcm_client_mock.cc

diff --git a/chrome/browser/services/gcm/gcm_client_mock.cc b/chrome/browser/services/gcm/gcm_client_mock.cc

index d924238005978d4019a9703494fc9d614e3cf6c1..b894efaa70c8996c3ad77e0c6aa64bae599382ee 100644

--- a/chrome/browser/services/gcm/gcm_client_mock.cc

+++ b/chrome/browser/services/gcm/gcm_client_mock.cc

@@ -143,7 +143,7 @@ void GCMClientMock::DeleteMessages(const std::string& app_id) {

// static

std::string GCMClientMock::GetRegistrationIdFromSenderIds(

const std::vector<std::string>& sender_ids) {

- // GCMProfileService normalizes the sender IDs by making them sorted.

+ // GCMService normalizes the sender IDs by making them sorted.

std::vector<std::string> normalized_sender_ids = sender_ids;

std::sort(normalized_sender_ids.begin(), normalized_sender_ids.end());