Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 225403008: aura: Remove old GL paths from RenderWidgetHostViewAura. (Closed)

Created:
6 years, 8 months ago by piman
Modified:
6 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, jochen+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

aura: Remove old GL paths from RenderWidgetHostViewAura. Frames from the renderer are either legacy software, software compositing, or ubercomp. Remove the old GL composited paths that are no longer in use. For layout tests, put them into composited mailbox mode, and instead of sending the frame to the browser at all, just put the frame in a post task to ack back directly to the renderer. Rebase and fix-up to prevent overloading the GPU process from https://codereview.chromium.org/131443007/ R=danakj BUG=332998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261990

Patch Set 1 #

Patch Set 2 : Delay swap ack until commands have executed #

Patch Set 3 : rebase #

Patch Set 4 : fix compile #

Patch Set 5 : s/interface/context/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -487 lines) Patch
M chrome/browser/about_flags.cc View 1 2 5 chunks +13 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 8 chunks +7 lines, -44 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 20 chunks +18 lines, -325 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 8 chunks +9 lines, -110 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 4 chunks +11 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 2 3 4 3 chunks +52 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
Love it, LGTM if the bots like it.
6 years, 8 months ago (2014-04-04 18:56:24 UTC) #1
danakj
Rebased too far forward I think, I sent some tryjobs @HEAD.
6 years, 8 months ago (2014-04-04 19:17:21 UTC) #2
danakj
On 2014/04/04 19:17:21, danakj wrote: > Rebased too far forward I think, I sent some ...
6 years, 8 months ago (2014-04-04 19:24:00 UTC) #3
piman
Success, I believe. The win layout test failures look common to other try runs of ...
6 years, 8 months ago (2014-04-05 01:15:32 UTC) #4
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-05 01:15:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/225403008/10009
6 years, 8 months ago (2014-04-05 01:15:41 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-05 07:53:51 UTC) #7
Message was sent while issue was closed.
Change committed as 261990

Powered by Google App Engine
This is Rietveld 408576698