Reduce window rectangles cap to 8

src/gpu/gl/GrGLGpu.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrGLGpu.h"
 #include "GrGLBuffer.h"
 #include "GrGLGLSL.h"
@@ skipping 1978 matching lines @@
                 fHWScissorSettings.fEnabled = kYes_TriState;
             }
             return;
         }
     }
 
     // See fall through note above
     this->disableScissor();
 }
 
+// Blah blah blah.

[bsalomon, 2016/08/22 13:21:57]

I like this better.

[csmartdalton, 2016/08/22 14:10:39]

This one doesn't seem to work.. The pragma needs to appear before GrGLIRect.h
gets included, but if we do that first it breaks a commit hook that likes the
includes to be first.

We might be able to sneak a couple includes before the pragma though, and then
do it before including GrGLIRect.h 

+// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=5912
+#define HAS_GCC_BUG defined(__GNUC__) && (__GNUC__ < 5) && !defined(__clang__)
+#if HAS_GCC_BUG
+#  pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
+
 void GrGLGpu::flushWindowRectangles(const GrWindowRectangles& windows, const GrGLRenderTarget* rt) {
     typedef GrWindowRectangles::Mode Mode;
     SkASSERT(windows.count() <= this->caps()->maxWindowRectangles());
     SkASSERT(windows.disabled() || rt->renderFBOID()); // Window rectangles can't be used on-screen.
 
     if (!this->caps()->maxWindowRectangles() ||
         fHWWindowRects.equal(rt->origin(), rt->getViewport(), windows)) {
         return;
 
     }
 
     GrGLIRect glwindows[GrWindowRectangles::kMaxWindows];
     const SkIRect* skwindows = windows.data();
     for (int i = 0; i < windows.count(); ++i) {
         glwindows[i].setRelativeTo(rt->getViewport(), skwindows[i], rt->origin());
     }
 
     GrGLenum glmode = (Mode::kExclusive == windows.mode()) ? GR_GL_EXCLUSIVE : GR_GL_INCLUSIVE;
     GL_CALL(WindowRectangles(glmode, windows.count(), glwindows->asInts()));
 
     fHWWindowRects.set(rt->origin(), rt->getViewport(), windows);
 }
 
+#if HAS_GCC_BUG
+#  pragma GCC diagnostic error "-Warray-bounds"
+#endif
+
 void GrGLGpu::disableWindowRectangles() {
     if (!this->caps()->maxWindowRectangles() || fHWWindowRects.disabled()) {
         return;
     }
     GL_CALL(WindowRectangles(GR_GL_EXCLUSIVE, 0, nullptr));
     fHWWindowRects.setDisabled();
 }
 
 void GrGLGpu::flushMinSampleShading(float minSampleShading) {
     if (fHWMinSampleShading != minSampleShading) {
@@ skipping 2625 matching lines @@
         if (GR_GL_TEXTURE_EXTERNAL == glTexture->target() ||
             GR_GL_TEXTURE_RECTANGLE == glTexture->target()) {
             copyParams->fFilter = GrTextureParams::kNone_FilterMode;
             copyParams->fWidth = texture->width();
             copyParams->fHeight = texture->height();
             return true;
         }
     }
     return false;
 }