media/midi/midi_manager_android.cc - Issue 2253943004: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/midi_manager_android.cc

Issue 2253943004: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/midi/midi_manager_android.cc

diff --git a/media/midi/midi_manager_android.cc b/media/midi/midi_manager_android.cc

index 54fe91514c903f3f1189be369fa316f017589d3f..4d4ec8042132144fd21de0744771bdac6d60c245 100644

--- a/media/midi/midi_manager_android.cc

+++ b/media/midi/midi_manager_android.cc

@@ -94,7 +94,7 @@ void MidiManagerAndroid::OnInitialized(

for (jsize i = 0; i < length; ++i) {

jobject raw_device = env->GetObjectArrayElement(devices, i);

- AddDevice(base::WrapUnique(new MidiDeviceAndroid(env, raw_device, this)));

+ AddDevice(base::MakeUnique<MidiDeviceAndroid>(env, raw_device, this));

}

CompleteInitialization(Result::OK);

}

@@ -102,7 +102,7 @@ void MidiManagerAndroid::OnInitialized(

void MidiManagerAndroid::OnAttached(JNIEnv* env,

const JavaParamRef<jobject>& caller,

const JavaParamRef<jobject>& raw_device) {

- AddDevice(base::WrapUnique(new MidiDeviceAndroid(env, raw_device, this)));

+ AddDevice(base::MakeUnique<MidiDeviceAndroid>(env, raw_device, this));

}

void MidiManagerAndroid::OnDetached(JNIEnv* env,

« no previous file with comments | « media/midi/midi_manager_alsa.cc ('k') | media/midi/usb_midi_device_factory_android.cc » ('j') | no next file with comments »